[chirp_devel] [PATCH 12/9] Move radios into their own directory (#2351)

[Kosta Arvanitis]

I think this is good.  I also prefer the radio source under the chirp tree, fwiw I would prefer also source (chirpui) under this tree as well so as so to make indexed source better.

Either drivers or radios is fine.  I would lean towards radio only because the classes in this folder would mostly inherit from radio. Either way good change imo.

Date: Wed, 25 Feb 2015 08:55:50 -0800
From: dsmith at danplanet.com
To: chirp_devel at intrepid.danplanet.com
Subject: Re: [chirp_devel] [PATCH 12/9] Move radios into their own directory (#2351)

> diff --git a/radio/__init__.py b/radio/__init__.py
> new file mode 100644
> index 0000000..726217b
> --- /dev/null
> +++ b/radio/__init__.py
 
This isn't okay, as it will generate a top-level module called 'radio'
if the package is installed on the system. I.e. it would look like this:
 
 >>> from radio import ic2820
 
This needs to be under chirp/, and I'd prefer "drivers".
 
Note that your chirpc rename patch did not work, as mercurial didn't
properly generate a follow-able rename change and instead just
deleted/added the old/new file(s). So, that means someone who uses
mercurial will have to generate that patch (jab).
 
Before we do, I'd like to ask the group whether they think this is
really something we need to change. I agree that chirp/ is very
cluttered, but I'm also not sure that it really matters. This massive
rename is kindof a hassle (and will break my muscle memory).
 
So: should we do this?
 
--Dan
 

_______________________________________________
chirp_devel mailing list
chirp_devel at intrepid.danplanet.com
http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20150225/0413be8f/attachment-0001.html