<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>I think this is good. I also prefer the radio source under the chirp tree, fwiw I would prefer also source (chirpui) under this tree as well so as so to make indexed source better.<br><br>Either drivers or radios is fine. I would lean towards radio only because the classes in this folder would mostly inherit from radio. Either way good change imo.<br><br>Date: Wed, 25 Feb 2015 08:55:50 -0800<br>From: dsmith@danplanet.com<br>To: chirp_devel@intrepid.danplanet.com<br>Subject: Re: [chirp_devel] [PATCH 12/9] Move radios into their own directory (#2351)<br><br><pre>> diff --git a/radio/__init__.py b/radio/__init__.py<br>> new file mode 100644<br>> index 0000000..726217b<br>> --- /dev/null<br>> +++ b/radio/__init__.py<br> <br>This isn't okay, as it will generate a top-level module called 'radio'<br>if the package is installed on the system. I.e. it would look like this:<br> <br> >>> from radio import ic2820<br> <br>This needs to be under chirp/, and I'd prefer "drivers".<br> <br>Note that your chirpc rename patch did not work, as mercurial didn't<br>properly generate a follow-able rename change and instead just<br>deleted/added the old/new file(s). So, that means someone who uses<br>mercurial will have to generate that patch (jab).<br> <br>Before we do, I'd like to ask the group whether they think this is<br>really something we need to change. I agree that chirp/ is very<br>cluttered, but I'm also not sure that it really matters. This massive<br>rename is kindof a hassle (and will break my muscle memory).<br> <br>So: should we do this?<br> <br>--Dan<br> <br></pre><br>_______________________________________________
chirp_devel mailing list
chirp_devel@intrepid.danplanet.com
http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers </div></body>
</html>