[chirp_devel] [PATCH 12/9] Move radios into their own directory (#2351)

[Zach Welch]

On 02/25/2015 08:55 AM, Dan Smith wrote:
>> diff --git a/radio/__init__.py b/radio/__init__.py
>> new file mode 100644
>> index 0000000..726217b
>> --- /dev/null
>> +++ b/radio/__init__.py
>
> This isn't okay, as it will generate a top-level module called 'radio'
> if the package is installed on the system. I.e. it would look like this:
 >
>   >>> from radio import ic2820
>
> This needs to be under chirp/, and I'd prefer "drivers".

To be clear, you want chirp/radio/ or chirp/drivers/?

I think "drivers" is too generic a term.  These are all radios.  If we 
have another class of drivers, they should go in a different directory, 
named appropriately.

Also, I agree with Kosta regarding the ui.  It should be chirp/ui/, but 
that would need to be a separate patch.

> Note that your chirpc rename patch did not work, as mercurial didn't
> properly generate a follow-able rename change and instead just
> deleted/added the old/new file(s). So, that means someone who uses
> mercurial will have to generate that patch (jab).

Deleting and adding is how git tracks files, and mercurial uses it as 
the storage engine.  Use 'hg log --follow chirpc', and you'll see the 
history is all there.

Cheers,
-- 
Zach Welch
Mandolin Creek Farm
www.mandolincreekfarm.com
farm: 541-453-4131
cell: 541-740-3410