[chirp_devel] [PATCH 12/9] Move radios into their own directory (#2351)
Dan Smith
Wed Feb 25 08:55:50 PST 2015
> diff --git a/radio/__init__.py b/radio/__init__.py
> new file mode 100644
> index 0000000..726217b
> --- /dev/null
> +++ b/radio/__init__.py
This isn't okay, as it will generate a top-level module called 'radio'
if the package is installed on the system. I.e. it would look like this:
>>> from radio import ic2820
This needs to be under chirp/, and I'd prefer "drivers".
Note that your chirpc rename patch did not work, as mercurial didn't
properly generate a follow-able rename change and instead just
deleted/added the old/new file(s). So, that means someone who uses
mercurial will have to generate that patch (jab).
Before we do, I'd like to ask the group whether they think this is
really something we need to change. I agree that chirp/ is very
cluttered, but I'm also not sure that it really matters. This massive
rename is kindof a hassle (and will break my muscle memory).
So: should we do this?
--Dan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20150225/2333a3bf/attachment-0001.bin
More information about the chirp_devel
mailing list