[chirp_devel] New Model #6259 Yaesu FT-7100

[Al Simons]

Bruno, in case you're not aware of it, JetBrains makes an excellent 
Python IDE, PyCharm.  It will flag all of the style issues identified 
below, and it also has an excellent Python debugger.  It has made my 
life easy for the past 5+ years.

PyCharm is available on all three major platforms. The free "community" 
version is all you'll need if you're just doing Python programming.  The 
paid Pro version brings in lots of other features that I use at work, 
but is quite steep.  For my hobby programming, I just use the community 
edition.

-Al

On 1/1/2019 11:29 AM, Dan Smith via chirp_devel wrote:
> Hi Bruno,
>
>> Patch in attachment.
>
> Sorry again for the late reply. I blame the holidays :)
>
> Your patch passed the functional tests, so I went ahead and applied, but it has a lot of style issues (output included below) that I would like to get fixed up. Can you submit another patch on top of the new repo with fixes for those when you get a chance?
>
> Also, I think you should address the commented-out code. It's generally bad form to have code commented out, which isn't very obvious to people not using syntax highlighting. The LOG.debug() messages are fine to just leave in as they will only be enabled when debugging is turned on. If they're not really useful anymore, just remove them.
>
> Thanks!
>
> --Dan
>
> ./chirp/drivers/ft7100.py:38:1: E302 expected 2 blank lines, found 1
> ./chirp/drivers/ft7100.py:40:5: E265 block comment should start with '# '
> ./chirp/drivers/ft7100.py:44:9: E265 block comment should start with '# '
> ./chirp/drivers/ft7100.py:47:80: E501 line too long (83 > 79 characters)
> ./chirp/drivers/ft7100.py:53:13: E128 continuation line under-indented for visual indent
>
[deleted...]