[chirp_devel] New Model #6259 Yaesu FT-7100

[Dan Smith]

Hi Bruno,

> Patch in attachment.


Sorry again for the late reply. I blame the holidays :)

Your patch passed the functional tests, so I went ahead and applied, but it has a lot of style issues (output included below) that I would like to get fixed up. Can you submit another patch on top of the new repo with fixes for those when you get a chance?

Also, I think you should address the commented-out code. It's generally bad form to have code commented out, which isn't very obvious to people not using syntax highlighting. The LOG.debug() messages are fine to just leave in as they will only be enabled when debugging is turned on. If they're not really useful anymore, just remove them.

Thanks!

--Dan

./chirp/drivers/ft7100.py:38:1: E302 expected 2 blank lines, found 1
./chirp/drivers/ft7100.py:40:5: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:44:9: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:47:80: E501 line too long (83 > 79 characters)
./chirp/drivers/ft7100.py:53:13: E128 continuation line under-indented for visual indent
./chirp/drivers/ft7100.py:55:1: E302 expected 2 blank lines, found 1
./chirp/drivers/ft7100.py:56:21: E261 at least two spaces before inline comment
./chirp/drivers/ft7100.py:57:5: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:60:1: E302 expected 2 blank lines, found 1
./chirp/drivers/ft7100.py:66:13: E128 continuation line under-indented for visual indent
./chirp/drivers/ft7100.py:68:1: E302 expected 2 blank lines, found 1
./chirp/drivers/ft7100.py:86:13: E128 continuation line under-indented for visual indent
./chirp/drivers/ft7100.py:92:5: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:93:5: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:101:9: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:102:9: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:131:1: E115 expected an indented block (comment)
./chirp/drivers/ft7100.py:133:32: E261 at least two spaces before inline comment
./chirp/drivers/ft7100.py:143:80: E501 line too long (80 > 79 characters)
./chirp/drivers/ft7100.py:510:16: E124 closing bracket does not match visual indentation
./chirp/drivers/ft7100.py:518:1: E302 expected 2 blank lines, found 1
./chirp/drivers/ft7100.py:522:1: E302 expected 2 blank lines, found 1
./chirp/drivers/ft7100.py:541:80: E501 line too long (116 > 79 characters)
./chirp/drivers/ft7100.py:544:26: E124 closing bracket does not match visual indentation
./chirp/drivers/ft7100.py:557:9: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:653:9: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:654:9: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:683:9: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:717:80: E501 line too long (90 > 79 characters)
./chirp/drivers/ft7100.py:763:9: E303 too many blank lines (2)
./chirp/drivers/ft7100.py:772:17: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:773:21: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:783:80: E501 line too long (80 > 79 characters)
./chirp/drivers/ft7100.py:808:16: E124 closing bracket does not match visual indentation
./chirp/drivers/ft7100.py:827:9: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:828:9: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:829:13: E116 unexpected indentation (comment)
./chirp/drivers/ft7100.py:829:13: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:830:17: E116 unexpected indentation (comment)
./chirp/drivers/ft7100.py:830:17: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:831:17: E116 unexpected indentation (comment)
./chirp/drivers/ft7100.py:831:17: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:832:9: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:833:13: E116 unexpected indentation (comment)
./chirp/drivers/ft7100.py:833:13: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:834:17: E116 unexpected indentation (comment)
./chirp/drivers/ft7100.py:834:17: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:835:17: E116 unexpected indentation (comment)
./chirp/drivers/ft7100.py:835:17: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:858:9: E301 expected 1 blank line, found 0
./chirp/drivers/ft7100.py:890:80: E501 line too long (84 > 79 characters)
./chirp/drivers/ft7100.py:914:9: E301 expected 1 blank line, found 0
./chirp/drivers/ft7100.py:934:80: E501 line too long (84 > 79 characters)
./chirp/drivers/ft7100.py:939:13: E301 expected 1 blank line, found 0
./chirp/drivers/ft7100.py:972:80: E501 line too long (89 > 79 characters)
./chirp/drivers/ft7100.py:984:19: E124 closing bracket does not match visual indentation
./chirp/drivers/ft7100.py:985:80: E501 line too long (83 > 79 characters)
./chirp/drivers/ft7100.py:990:80: E501 line too long (84 > 79 characters)
./chirp/drivers/ft7100.py:991:13: E301 expected 1 blank line, found 0
./chirp/drivers/ft7100.py:1067:80: E501 line too long (83 > 79 characters)
./chirp/drivers/ft7100.py:1071:80: E501 line too long (83 > 79 characters)
./chirp/drivers/ft7100.py:1104:25: E711 comparison to None should be 'if cond is None:'
./chirp/drivers/ft7100.py:1112:25: E711 comparison to None should be 'if cond is None:'
./chirp/drivers/ft7100.py:1121:9: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:1121:80: E501 line too long (97 > 79 characters)
./chirp/drivers/ft7100.py:1145:1: E302 expected 2 blank lines, found 1
./chirp/drivers/ft7100.py:1152:80: E501 line too long (116 > 79 characters)
./chirp/drivers/ft7100.py:1169:13: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:1187:1: E302 expected 2 blank lines, found 1
./chirp/drivers/ft7100.py:1194:80: E501 line too long (116 > 79 characters)
./chirp/drivers/ft7100.py:1205:80: E501 line too long (80 > 79 characters)
./chirp/drivers/ft7100.py:1212:13: E265 block comment should start with '# '
./chirp/drivers/ft7100.py:1230:1: W391 blank line at end of file