[chirp_devel] New Model #6259 Yaesu FT-7100
Bruno
Sat Jan 5 03:11:05 PST 2019
Hi Dan
> Sorry again for the late reply. I blame the holidays :)
I think the opposite is true. There is nothing to blame. I would like to thank
you very much for your work and I hope that you had a good time.
> Your patch passed the functional tests, so I went ahead and applied, but it
> has a lot of style issues (output included below) that I would like to get
> fixed up.
I haven't found out what is wrong with my setup.
If I execute:
~/chirp.hg/chirp/drivers$ tox
I get no style errors:
------------------------------
GLOB sdist-make: /home/bm/chirp.hg/setup.py
unit inst-nodeps: /home/bm/chirp.hg/.tox/.tmp/package/1/chirp-0.3.0dev.zip
unit installed:
astroid==1.2.1,chardet==2.3.0,Cheetah==2.4.4,chirp==0.3.0.dev0,colorama==0.3.2,decorator==3.4.0,defusedxml==0.4.1,docutils==0.12,filelock==3.0.10,fpconst==0.7.2,funcsigs==1.0.2,html5lib==0.999,ipdb==0.8,ipython==2.3.0,libsigrok==0.5.0,logilab-
common==0.62.0,lxml==3.4.0,meld==3.12.1,mercurial==3.1.2,mock==2.0.0,mox==0.5.3,nose==1.3.7,numpy==1.8.2,pbr==5.1.1,pep8==1.7.1,pexpect==3.2,Pillow==2.6.1,pluggy==0.8.0,py==1.7.0,pycrypto==2.6.1,pycups==1.9.63,pycurl==7.19.5,pygobject==3.14.0,pylint==1.3.1,PyOpenGL==3.0.2,pyserial==2.6,pysmbc==1.0.15.3,python-
apt==0.9.3.12,python-debian==0.1.27,python-
debianbts==1.11,reportbug==6.6.3,reportlab==3.1.8,requests==2.4.3,roman==2.0.0,scipy==0.14.0,simplegeneric==0.8.1,six==1.9.0,SOAPpy==0.12.22,toml==0.10.0,tox==3.5.3,urllib3==1.9.1,vboxapi==1.0,virtualenv==16.1.0,winpdb==1.4.8,wstools==0.4.3,wxPython==3.0.1.1,wxPython-
common==3.0.1.1
unit run-test-pre: PYTHONHASHSEED='272860871'
unit runtests: commands[0] | nosetests -v tests/unit
test_bit_array (tests.unit.test_bitwise.TestBitType) ... ok
test_bit_array_fail (tests.unit.test_bitwise.TestBitType) ... ok
...
style inst-nodeps: /home/bm/chirp.hg/.tox/.tmp/package/1/chirp-0.3.0dev.zip
style installed:
astroid==1.2.1,chardet==2.3.0,Cheetah==2.4.4,chirp==0.3.0.dev0,colorama==0.3.2,decorator==3.4.0,defusedxml==0.4.1,docutils==0.12,filelock==3.0.10,fpconst==0.7.2,html5lib==0.999,ipdb==0.8,ipython==2.3.0,libsigrok==0.5.0,logilab-
common==0.62.0,lxml==3.4.0,meld==3.12.1,mercurial==3.1.2,numpy==1.8.2,pep8==1.6.2,pexpect==3.2,Pillow==2.6.1,pluggy==0.8.0,py==1.7.0,pycrypto==2.6.1,pycups==1.9.63,pycurl==7.19.5,pygobject==3.14.0,pylint==1.3.1,PyOpenGL==3.0.2,pyserial==2.6,pysmbc==1.0.15.3,python-
apt==0.9.3.12,python-debian==0.1.27,python-
debianbts==1.11,reportbug==6.6.3,reportlab==3.1.8,requests==2.4.3,roman==2.0.0,scipy==0.14.0,simplegeneric==0.8.1,six==1.9.0,SOAPpy==0.12.22,toml==0.10.0,tox==3.5.3,urllib3==1.9.1,vboxapi==1.0,virtualenv==16.1.0,winpdb==1.4.8,wstools==0.4.3,wxPython==3.0.1.1,wxPython-
common==3.0.1.1
style run-test-pre: PYTHONHASHSEED='272860871'
style runtests: commands[0] | python ./tools/cpep8.py
_______________________________________________________ summary
________________________________________________________
unit: commands succeeded
driver: commands succeeded
style: commands succeeded
congratulations :)
------------------------------
In order to get the style errors I have to run:
~/chirp.hg/chirp/drivers$ python ../../tools/cpep8.py ./ft7100.py
Now all style errors are fixed.
Commented-out code is removed.
Clariifed some comments.
Patch in attachment.
Best regards,
Bruno
> Also, I think you should address the commented-out code. It's generally bad
> form to have code commented out, which isn't very obvious to people not
> using syntax highlighting. The LOG.debug() messages are fine to just leave
> in as they will only be enabled when debugging is turned on. If they're not
> really useful anymore, just remove them.
>
> Thanks!
>
> --Dan
>
> ./chirp/drivers/ft7100.py:38:1: E302 expected 2 blank lines, found 1
> ./chirp/drivers/ft7100.py:40:5: E265 block comment should start with '# '
> ./chirp/drivers/ft7100.py:44:9: E265 block comment should start with '# '
> ./chirp/drivers/ft7100.py:47:80: E501 line too long (83 > 79 characters)
> ./chirp/drivers/ft7100.py:53:13: E128 continuation line under-indented for
> visual indent ./chirp/drivers/ft7100.py:55:1: E302 expected 2 blank lines,
> found 1 ./chirp/drivers/ft7100.py:56:21: E261 at least two spaces before
> inline comment ./chirp/drivers/ft7100.py:57:5: E265 block comment should
> start with '# ' ./chirp/drivers/ft7100.py:60:1: E302 expected 2 blank
> lines, found 1 ./chirp/drivers/ft7100.py:66:13: E128 continuation line
> under-indented for visual indent ./chirp/drivers/ft7100.py:68:1: E302
> expected 2 blank lines, found 1 ./chirp/drivers/ft7100.py:86:13: E128
> continuation line under-indented for visual indent
> ./chirp/drivers/ft7100.py:92:5: E265 block comment should start with '# '
> ./chirp/drivers/ft7100.py:93:5: E265 block comment should start with '# '
> ./chirp/drivers/ft7100.py:101:9: E265 block comment should start with '# '
> ./chirp/drivers/ft7100.py:102:9: E265 block comment should start with '# '
> ./chirp/drivers/ft7100.py:131:1: E115 expected an indented block (comment)
> ./chirp/drivers/ft7100.py:133:32: E261 at least two spaces before inline
> comment ./chirp/drivers/ft7100.py:143:80: E501 line too long (80 > 79
> characters) ./chirp/drivers/ft7100.py:510:16: E124 closing bracket does not
> match visual indentation ./chirp/drivers/ft7100.py:518:1: E302 expected 2
> blank lines, found 1 ./chirp/drivers/ft7100.py:522:1: E302 expected 2 blank
> lines, found 1 ./chirp/drivers/ft7100.py:541:80: E501 line too long (116 >
> 79 characters) ./chirp/drivers/ft7100.py:544:26: E124 closing bracket does
> not match visual indentation ./chirp/drivers/ft7100.py:557:9: E265 block
> comment should start with '# ' ./chirp/drivers/ft7100.py:653:9: E265 block
> comment should start with '# ' ./chirp/drivers/ft7100.py:654:9: E265 block
> comment should start with '# ' ./chirp/drivers/ft7100.py:683:9: E265 block
> comment should start with '# ' ./chirp/drivers/ft7100.py:717:80: E501 line
> too long (90 > 79 characters) ./chirp/drivers/ft7100.py:763:9: E303 too
> many blank lines (2)
> ./chirp/drivers/ft7100.py:772:17: E265 block comment should start with '# '
> ./chirp/drivers/ft7100.py:773:21: E265 block comment should start with '# '
> ./chirp/drivers/ft7100.py:783:80: E501 line too long (80 > 79 characters)
> ./chirp/drivers/ft7100.py:808:16: E124 closing bracket does not match visual
> indentation ./chirp/drivers/ft7100.py:827:9: E265 block comment should
> start with '# ' ./chirp/drivers/ft7100.py:828:9: E265 block comment should
> start with '# ' ./chirp/drivers/ft7100.py:829:13: E116 unexpected
> indentation (comment) ./chirp/drivers/ft7100.py:829:13: E265 block comment
> should start with '# ' ./chirp/drivers/ft7100.py:830:17: E116 unexpected
> indentation (comment) ./chirp/drivers/ft7100.py:830:17: E265 block comment
> should start with '# ' ./chirp/drivers/ft7100.py:831:17: E116 unexpected
> indentation (comment) ./chirp/drivers/ft7100.py:831:17: E265 block comment
> should start with '# ' ./chirp/drivers/ft7100.py:832:9: E265 block comment
> should start with '# ' ./chirp/drivers/ft7100.py:833:13: E116 unexpected
> indentation (comment) ./chirp/drivers/ft7100.py:833:13: E265 block comment
> should start with '# ' ./chirp/drivers/ft7100.py:834:17: E116 unexpected
> indentation (comment) ./chirp/drivers/ft7100.py:834:17: E265 block comment
> should start with '# ' ./chirp/drivers/ft7100.py:835:17: E116 unexpected
> indentation (comment) ./chirp/drivers/ft7100.py:835:17: E265 block comment
> should start with '# ' ./chirp/drivers/ft7100.py:858:9: E301 expected 1
> blank line, found 0 ./chirp/drivers/ft7100.py:890:80: E501 line too long
> (84 > 79 characters) ./chirp/drivers/ft7100.py:914:9: E301 expected 1 blank
> line, found 0 ./chirp/drivers/ft7100.py:934:80: E501 line too long (84 > 79
> characters) ./chirp/drivers/ft7100.py:939:13: E301 expected 1 blank line,
> found 0 ./chirp/drivers/ft7100.py:972:80: E501 line too long (89 > 79
> characters) ./chirp/drivers/ft7100.py:984:19: E124 closing bracket does not
> match visual indentation ./chirp/drivers/ft7100.py:985:80: E501 line too
> long (83 > 79 characters) ./chirp/drivers/ft7100.py:990:80: E501 line too
> long (84 > 79 characters) ./chirp/drivers/ft7100.py:991:13: E301 expected 1
> blank line, found 0 ./chirp/drivers/ft7100.py:1067:80: E501 line too long
> (83 > 79 characters) ./chirp/drivers/ft7100.py:1071:80: E501 line too long
> (83 > 79 characters) ./chirp/drivers/ft7100.py:1104:25: E711 comparison to
> None should be 'if cond is None:' ./chirp/drivers/ft7100.py:1112:25: E711
> comparison to None should be 'if cond is None:'
> ./chirp/drivers/ft7100.py:1121:9: E265 block comment should start with '# '
> ./chirp/drivers/ft7100.py:1121:80: E501 line too long (97 > 79 characters)
> ./chirp/drivers/ft7100.py:1145:1: E302 expected 2 blank lines, found 1
> ./chirp/drivers/ft7100.py:1152:80: E501 line too long (116 > 79 characters)
> ./chirp/drivers/ft7100.py:1169:13: E265 block comment should start with '#
> ' ./chirp/drivers/ft7100.py:1187:1: E302 expected 2 blank lines, found 1
> ./chirp/drivers/ft7100.py:1194:80: E501 line too long (116 > 79 characters)
> ./chirp/drivers/ft7100.py:1205:80: E501 line too long (80 > 79 characters)
> ./chirp/drivers/ft7100.py:1212:13: E265 block comment should start with '#
> ' ./chirp/drivers/ft7100.py:1230:1: W391 blank line at end of file
>
> _______________________________________________
> chirp_devel mailing list
> chirp_devel at intrepid.danplanet.com
> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
> Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mypatch.patch
Type: text/x-patch
Size: 20336 bytes
Desc: not available
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20190105/d47e17c3/attachment-0001.bin
More information about the chirp_devel
mailing list