[chirp_devel] [PATCH 12/9] Move radios into their own directory (#2351)

[Dan Smith]

> To be clear, you want chirp/radio/ or chirp/drivers/?

Yes.

> I think "drivers" is too generic a term.  These are all radios.  If we 
> have another class of drivers, they should go in a different directory, 
> named appropriately.

They are not all radios. There are storage formats in there, repeaters,
and APRS units. They're all drivers, and "drivers" is my preference for
the module name.

> Also, I agree with Kosta regarding the ui.  It should be chirp/ui/, but 
> that would need to be a separate patch.

Yep.

> Deleting and adding is how git tracks files, and mercurial uses it as 
> the storage engine.

Why do you keep saying this? Unless something has changed recently in
either tool, this definitely not the case. Mercurial uses revlog, which
is similar in concept, but significantly different in practice.

Either way, the patch handling and event recording could easily be
different depending on the tool, regardless of the eventual persistence.

> Use 'hg log --follow chirpc', and you'll see the  history is all there.

When I "hg import" your patch, --follow does not show the history. When
I "hg rename" it, it does. As such, I didn't apply your patch, did the
rename myself, and committed it with your authorship, which is why the
repository shows the correct history.

If you actually used mercurial to try to apply your patch to a copy of
the tree from before I applied the proper fix, you'll see the history is
not maintained.

--Dan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20150225/b8dd1e73/attachment-0001.bin