[chirp_devel] [PATCH] [py2 default branch] Minor change to variable usage in update_recent_files() #8007

[Rudolph Gutzerhagen]

Okay, I'll fess up, this change request relates to sloppy coding in the
original submission.
The original coding intent was to set up a set of consistent variable names
for use in a function call.
In one of those phone-dog-kid distractions, the edit was not fully
completed.
The editor did not throw a "variable defined but not used" warning (of
course not, no compile, and linting not triggered, and cpep8 not set to
catch these).
Execution testing was fine as old variable still had valid data.
The issue was noticed later when eyeballing the code for other reasons.
OCD kicks in and change has to be made.
As a code reviewer, having dealt countlessly with "what: Change why: per
John" submissions, I thought my explanation was savvy.
So now do I get to say, whot? the code is self-documenting, can't you read
it?  ;-)
Okay, I understand exactly your point from having suffered much as a
reviewer myself.
Time to fess up on the sloppy explanation.
Thanks for your patience. My apologies.


On Thu, Feb 11, 2021 at 5:28 PM Dan Smith via chirp_devel <
chirp_devel at intrepid.danplanet.com> wrote:

> > # HG changeset patch
> > # User Rudolph Gutzerhagen <rudolph.gutzerhagen at gmail.com>
> > # Date 1611170343 18000
> > #      Wed Jan 20 14:19:03 2021 -0500
> > # Node ID a8d537e8573dd2ece22c03b67b51e87c26f14c27
> > # Parent  3a755fd42e974c0f26b13a2643b4ba7da99a528f
> > Minor change to variable usage in update_recent_files()   #8007
>
> In the future, please actually describe what you're doing in a patch.
> Saying "I'm changing something" is obvious and not helpful.
>
> I'm going to apply this because it's tiny, doesn't seem to break anything,
> has a bug id, and I made you wait. But I don't know why you're doing it, so
> please reply and explain :)
>
> --Dan
> _______________________________________________
> chirp_devel mailing list
> chirp_devel at intrepid.danplanet.com
> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
> Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20210211/07a1823b/attachment-0001.html