<div dir="ltr">Okay, I'll fess up, this change request relates to sloppy coding in the original submission. <div>The original coding intent was to set up a set of consistent variable names for use in a function call.</div><div>In one of those phone-dog-kid distractions, the edit was not fully completed. </div><div>The editor did not throw a "variable defined but not used" warning (of course not, no compile, and linting not triggered, and cpep8 not set to catch these).</div><div>Execution testing was fine as old variable still had valid data.</div><div>The issue was noticed later when eyeballing the code for other reasons.</div><div>OCD kicks in and change has to be made.</div><div>As a code reviewer, having dealt countlessly with "what: Change why: per John" submissions, I thought my explanation was savvy.</div><div>So now do I get to say, whot? the code is self-documenting, can't you read it? ;-)</div><div>Okay, I understand exactly your point from having suffered much as a reviewer myself.</div><div>Time to fess up on the sloppy explanation.</div><div>Thanks for your patience. My apologies.</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 11, 2021 at 5:28 PM Dan Smith via chirp_devel <<a href="mailto:chirp_devel@intrepid.danplanet.com" target="_blank">chirp_devel@intrepid.danplanet.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> # HG changeset patch<br>
> # User Rudolph Gutzerhagen <<a href="mailto:rudolph.gutzerhagen@gmail.com" target="_blank">rudolph.gutzerhagen@gmail.com</a>><br>
> # Date 1611170343 18000<br>
> # Wed Jan 20 14:19:03 2021 -0500<br>
> # Node ID a8d537e8573dd2ece22c03b67b51e87c26f14c27<br>
> # Parent 3a755fd42e974c0f26b13a2643b4ba7da99a528f<br>
> Minor change to variable usage in update_recent_files() #8007<br>
<br>
In the future, please actually describe what you're doing in a patch. Saying "I'm changing something" is obvious and not helpful.<br>
<br>
I'm going to apply this because it's tiny, doesn't seem to break anything, has a bug id, and I made you wait. But I don't know why you're doing it, so please reply and explain :)<br>
<br>
--Dan<br>
_______________________________________________<br>
chirp_devel mailing list<br>
<a href="mailto:chirp_devel@intrepid.danplanet.com" target="_blank">chirp_devel@intrepid.danplanet.com</a><br>
<a href="http://intrepid.danplanet.com/mailman/listinfo/chirp_devel" rel="noreferrer" target="_blank">http://intrepid.danplanet.com/mailman/listinfo/chirp_devel</a><br>
Developer docs: <a href="http://chirp.danplanet.com/projects/chirp/wiki/Developers" rel="noreferrer" target="_blank">http://chirp.danplanet.com/projects/chirp/wiki/Developers</a><br>
</blockquote></div>