[chirp_devel] [PATCH] [vx8] #129, #1735 (same issue): fix for incorrect channel initializations

[Bernhard Hailer]

Hi Dan,

sure, this can be removed. I originally wanted to remove the line below, 
but then tox failed because it expected some other values than just a 
default. Do you want me to submit a patch, or can you do it while adding 
to the branch?

Actually, we should find a way to use a default step value when a 
channel is freshly used, otherwise the previously used values (memory 
residues) will be written. As you stated yourself,  VX-8 does a pretty 
poor job in cleaning memories when a channel is erased.


73
Bernhard

On 02-Jan-20 14:26, Dan Smith via chirp_devel wrote:
>> @directory.register
>> @@ -701,6 +710,7 @@
>>          _mem.duplex = DUPLEX.index(mem.duplex)
>>          _mem.mode = MODES.index(mem.mode)
>>          _mem.dcs = chirp_common.DTCS_CODES.index(mem.dtcs)
>> +        # Radio doesn't do that when programmed manually, but tox needs it:
> Did you mean to remove this? It's adding a comment but not making any change, so I thought maybe it was residue. Also, it doesn't really make sense -- tox is just a venv manager for a test harness. Perhaps you mean something in one of the tests "needs" something, but I'm not sure what that would be. The tests are just asking the driver to store and retrieve things into the memory, so the *tests* don't really need anything specific.
>
> Can you either remove this line if not relevant, or re-word it to be more informative?
>
> Otherwise the change looks good to me, thanks for figuring that out!
>
> --Dan
> _______________________________________________
> chirp_devel mailing list
> chirp_devel at intrepid.danplanet.com
> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
> Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20200102/8ba444d3/attachment-0001.html