[chirp_devel] [PATCH] [vx8] #129, #1735 (same issue): fix for incorrect channel initializations

Dan Smith
Thu Jan 2 14:26:25 PST 2020


> @directory.register
> @@ -701,6 +710,7 @@
>         _mem.duplex = DUPLEX.index(mem.duplex)
>         _mem.mode = MODES.index(mem.mode)
>         _mem.dcs = chirp_common.DTCS_CODES.index(mem.dtcs)
> +        # Radio doesn't do that when programmed manually, but tox needs it:

Did you mean to remove this? It's adding a comment but not making any change, so I thought maybe it was residue. Also, it doesn't really make sense -- tox is just a venv manager for a test harness. Perhaps you mean something in one of the tests "needs" something, but I'm not sure what that would be. The tests are just asking the driver to store and retrieve things into the memory, so the *tests* don't really need anything specific.

Can you either remove this line if not relevant, or re-word it to be more informative?

Otherwise the change looks good to me, thanks for figuring that out!

--Dan


More information about the chirp_devel mailing list