[chirp_devel] New Driver submission

[Ian Harris]

Also my callsign is VA3IHX not W2OOT ;)

+# And thanks to Ian Harris (W2OOT) for decoding the mamory map.

On Fri, May 31, 2019 at 1:34 PM Dan Smith via chirp_devel <
chirp_devel at intrepid.danplanet.com> wrote:

> > # HG changeset patch
> > # User Rick DeWitt <aa0rd at yahoo.com>
> > # Date 1559226735 25200
> > #      Thu May 30 07:32:15 2019 -0700
> > # Node ID 120e390016146e92f490619e4f7029ae60418d72
> > # Parent  76c88493bd3f873d355d08e66c624c6acf201b4d
> > [th-uv8000] New driver for TYT TH-UV8000 family, fixes issue #2837
> >
> > Submitting new driver in support of 11 issues 2837 ... 6183
>
> I didn't check them all, but I don't see a test image in the patch or in
> issue #2837. Can you attach one there so I can run tests?
>
> Also, you need to add the file to tools/cpep8.manifest and run the style
> checks. There are 76 errors when I do that and run "tox -estyle" locally.
>
> > diff -r 76c88493bd3f -r 120e39001614 chirp/drivers/th_uv8000.py
> > --- /dev/null Thu Jan 01 00:00:00 1970 +0000
> > +++ b/chirp/drivers/th_uv8000.py      Thu May 30 07:32:15 2019 -0700
> > @@ -0,0 +1,1598 @@
> > +# Copyright 2019: Rick DeWitt (RJD), <aa0rd at yahoo.com>
> > +# Version 1.0 for TYT-UV8000D/E
> > +# Thanks to Damon Schaefer (K9CQB)and the Loudoun County, VA ARES
> > +#    club for the donated radio.
> > +# And thanks to Ian Harris (W2OOT) for decoding the mamory map.
>
> Unless I'm misunderstanding what went on, I think "memory" is misspelled
> above :)
>
> > +def _clean_buffer(radio):
> > +    radio.pipe.timeout = 0.005
> > +    junk = radio.pipe.read(256)
> > +    radio.pipe.timeout = STIMEOUT
> > +    if junk:
> > +        Log.debug("Got %i bytes of junk before starting" % len(junk))
>
> This line will fail with NameError, I think, as "Log" shouldn't be defined.
>
> > +def _recv(radio, addr, length):
> > +    """Get data from the radio """
> > +
> > +    data = _rawrecv(radio, length)
> > +
> > +    # DEBUG
> > +    LOG.info("Response:")
> > +    LOG.debug(util.hexprint(data))
>
> This doesn't make sense...to log a prefix at one level and the actual info
> at another. This should all be at debug level, and all in one log statement.
>
> I'll look in more detail when you've got the style changes done and I can
> run tests against an image.
>
> Thanks!
>
> --Dan
> _______________________________________________
> chirp_devel mailing list
> chirp_devel at intrepid.danplanet.com
> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
> Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20190531/48056989/attachment-0001.html