<div dir="ltr">Also my callsign is VA3IHX not W2OOT ;)<div><div><br></div><div>+# And thanks to Ian Harris (W2OOT) for decoding the mamory map. <br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 31, 2019 at 1:34 PM Dan Smith via chirp_devel <<a href="mailto:chirp_devel@intrepid.danplanet.com">chirp_devel@intrepid.danplanet.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> # HG changeset patch<br>
> # User Rick DeWitt <<a href="mailto:aa0rd@yahoo.com" target="_blank">aa0rd@yahoo.com</a>><br>
> # Date 1559226735 25200<br>
> # Thu May 30 07:32:15 2019 -0700<br>
> # Node ID 120e390016146e92f490619e4f7029ae60418d72<br>
> # Parent 76c88493bd3f873d355d08e66c624c6acf201b4d<br>
> [th-uv8000] New driver for TYT TH-UV8000 family, fixes issue #2837<br>
> <br>
> Submitting new driver in support of 11 issues 2837 ... 6183<br>
<br>
I didn't check them all, but I don't see a test image in the patch or in issue #2837. Can you attach one there so I can run tests?<br>
<br>
Also, you need to add the file to tools/cpep8.manifest and run the style checks. There are 76 errors when I do that and run "tox -estyle" locally.<br>
<br>
> diff -r 76c88493bd3f -r 120e39001614 chirp/drivers/th_uv8000.py<br>
> --- /dev/null Thu Jan 01 00:00:00 1970 +0000<br>
> +++ b/chirp/drivers/th_uv8000.py Thu May 30 07:32:15 2019 -0700<br>
> @@ -0,0 +1,1598 @@<br>
> +# Copyright 2019: Rick DeWitt (RJD), <<a href="mailto:aa0rd@yahoo.com" target="_blank">aa0rd@yahoo.com</a>><br>
> +# Version 1.0 for TYT-UV8000D/E<br>
> +# Thanks to Damon Schaefer (K9CQB)and the Loudoun County, VA ARES <br>
> +# club for the donated radio.<br>
> +# And thanks to Ian Harris (W2OOT) for decoding the mamory map.<br>
<br>
Unless I'm misunderstanding what went on, I think "memory" is misspelled above :)<br>
<br>
> +def _clean_buffer(radio):<br>
> + radio.pipe.timeout = 0.005<br>
> + junk = radio.pipe.read(256)<br>
> + radio.pipe.timeout = STIMEOUT<br>
> + if junk:<br>
> + Log.debug("Got %i bytes of junk before starting" % len(junk))<br>
<br>
This line will fail with NameError, I think, as "Log" shouldn't be defined.<br>
<br>
> +def _recv(radio, addr, length):<br>
> + """Get data from the radio """<br>
> +<br>
> + data = _rawrecv(radio, length)<br>
> +<br>
> + # DEBUG<br>
> + LOG.info("Response:")<br>
> + LOG.debug(util.hexprint(data))<br>
<br>
This doesn't make sense...to log a prefix at one level and the actual info at another. This should all be at debug level, and all in one log statement.<br>
<br>
I'll look in more detail when you've got the style changes done and I can run tests against an image.<br>
<br>
Thanks!<br>
<br>
--Dan<br>
_______________________________________________<br>
chirp_devel mailing list<br>
<a href="mailto:chirp_devel@intrepid.danplanet.com" target="_blank">chirp_devel@intrepid.danplanet.com</a><br>
<a href="http://intrepid.danplanet.com/mailman/listinfo/chirp_devel" rel="noreferrer" target="_blank">http://intrepid.danplanet.com/mailman/listinfo/chirp_devel</a><br>
Developer docs: <a href="http://chirp.danplanet.com/projects/chirp/wiki/Developers" rel="noreferrer" target="_blank">http://chirp.danplanet.com/projects/chirp/wiki/Developers</a><br>
</blockquote></div>