[chirp_devel] [Patch][ft4] Tone and upload fixes #4787
Dan Clemmensen
Mon Feb 25 13:42:14 PST 2019
Dan, you MUST be the "stickler". You have kept this project going for many
years, and somebody must provide the guidance for such a project or it will
begin to bitrot. I even knew this big patch was a bad idea. It won't hurt
me to do it right.
On Mon, Feb 25, 2019 at 1:38 PM Dan Smith via chirp_devel <
chirp_devel at intrepid.danplanet.com> wrote:
> > >> 3) through N): incremental fixups, each addressing a specific issue.
> > >This would be great thanks. So just to be clear you're doing that for
> this patch or just in the future?
> >
> > Sigh. I guess I'd better start from the very first one: the "patch"
> (i.e. the whole file) named add_ft4. You should therefore ignore my most
> recent (i.e, only other) patch.
> > This will take awhile, so I may submit some intermediates one at a time.
> If I get ambitious I will submit multiple patches in a set. So, my proposed
> > methodology is to pull a completely fresh repository, then begin a cycle
> of creating and soft-committing incremental patches, and then producing the
> > multi-patch single submittal.
>
> Okay, well, like I said, if you want to split this one into just maybe two
> pieces, even that would help.
>
> Sorry for being a stickler, but really appreciate you spending a little
> time making it cleaner. Whoever has to read history and support this driver
> in five years (even if it's you) will appreciate it too :)
>
> > Is it acceptable to continue to use issue #4787 at least until I catch
> up?
>
> Yep, there doesn't need to be a 1:1 issue:patch ratio :)
>
> --Dan
> _______________________________________________
> chirp_devel mailing list
> chirp_devel at intrepid.danplanet.com
> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
> Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20190225/fc67b55f/attachment-0001.html
More information about the chirp_devel
mailing list