<div dir="ltr">Dan, you MUST be the "stickler". You have kept this project going for many years, and somebody must provide the guidance for such a project or it will begin to bitrot. I even knew this big patch was a bad idea. It won't hurt me to do it right.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Feb 25, 2019 at 1:38 PM Dan Smith via chirp_devel <<a href="mailto:chirp_devel@intrepid.danplanet.com">chirp_devel@intrepid.danplanet.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> >> 3) through N): incremental fixups, each addressing a specific issue.<br>
> >This would be great thanks. So just to be clear you're doing that for this patch or just in the future?<br>
> <br>
> Sigh. I guess I'd better start from the very first one: the "patch" (i.e. the whole file) named add_ft4. You should therefore ignore my most recent (i.e, only other) patch.<br>
> This will take awhile, so I may submit some intermediates one at a time. If I get ambitious I will submit multiple patches in a set. So, my proposed <br>
> methodology is to pull a completely fresh repository, then begin a cycle of creating and soft-committing incremental patches, and then producing the<br>
> multi-patch single submittal.<br>
<br>
Okay, well, like I said, if you want to split this one into just maybe two pieces, even that would help.<br>
<br>
Sorry for being a stickler, but really appreciate you spending a little time making it cleaner. Whoever has to read history and support this driver in five years (even if it's you) will appreciate it too :)<br>
<br>
> Is it acceptable to continue to use issue #4787 at least until I catch up?<br>
<br>
Yep, there doesn't need to be a 1:1 issue:patch ratio :)<br>
<br>
--Dan<br>
_______________________________________________<br>
chirp_devel mailing list<br>
<a href="mailto:chirp_devel@intrepid.danplanet.com" target="_blank">chirp_devel@intrepid.danplanet.com</a><br>
<a href="http://intrepid.danplanet.com/mailman/listinfo/chirp_devel" rel="noreferrer" target="_blank">http://intrepid.danplanet.com/mailman/listinfo/chirp_devel</a><br>
Developer docs: <a href="http://chirp.danplanet.com/projects/chirp/wiki/Developers" rel="noreferrer" target="_blank">http://chirp.danplanet.com/projects/chirp/wiki/Developers</a><br>
</blockquote></div>