[chirp_devel] [PATCH] Add test case for settings

[Kosta Arvanitis]

I agree; thanks for clarifying and I will resubmit the patch.
 
Also, what is required to be possible to access the issue tracker so that I can close off some of these bugs?
 

 
Date: Thu, 22 Jan 2015 07:50:53 -0800
From: dsmith at danplanet.com
To: chirp_devel at intrepid.danplanet.com
Subject: Re: [chirp_devel] [PATCH] Add test case for settings

> +        '''
>          _limit = int(self._memobj.limits.lower_vhf) / 10
>          rs = RadioSetting("limits.lower_vhf", "VHF Lower Limit (115-239 MHz)",
>                            RadioSettingValueInteger(115, 235, _limit))
> @@ -429,7 +431,9 @@
>              obj.lower_vhf = value
>          rs.set_apply_callback(apply_limit, self._memobj.limits)
>          basic.append(rs)
> +        '''
 
It's really confusing to comment out code like this. I'd prefer that we
don't comment out code at all, but if necessary, please use hash marks.
Since we have version control, I'd rather you just remove these if
they're buggy and add them back when they're fixed.
 
Thanks!
 
--Dan
 

_______________________________________________
chirp_devel mailing list
chirp_devel at intrepid.danplanet.com
http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20150122/9206a691/attachment-0001.html