<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>I agree; thanks for clarifying and I will resubmit the patch.<BR> <BR>Also, what is required to be possible to access the issue tracker so that I can close off some of these bugs?<BR> <BR><br> <BR><div>Date: Thu, 22 Jan 2015 07:50:53 -0800<br>From: dsmith@danplanet.com<br>To: chirp_devel@intrepid.danplanet.com<br>Subject: Re: [chirp_devel] [PATCH] Add test case for settings<br><br><pre>> + '''<br>> _limit = int(self._memobj.limits.lower_vhf) / 10<br>> rs = RadioSetting("limits.lower_vhf", "VHF Lower Limit (115-239 MHz)",<br>> RadioSettingValueInteger(115, 235, _limit))<br>> @@ -429,7 +431,9 @@<br>> obj.lower_vhf = value<br>> rs.set_apply_callback(apply_limit, self._memobj.limits)<br>> basic.append(rs)<br>> + '''<br> <br>It's really confusing to comment out code like this. I'd prefer that we<br>don't comment out code at all, but if necessary, please use hash marks.<br>Since we have version control, I'd rather you just remove these if<br>they're buggy and add them back when they're fixed.<br> <br>Thanks!<br> <br>--Dan<br> <br></pre><br>_______________________________________________
chirp_devel mailing list
chirp_devel@intrepid.danplanet.com
http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers</div> </div></body>
</html>