[chirp_devel] patch issue 1353 TH9800 basic support

jml
Thu Jan 1 13:06:34 PST 2015


OK I have fixed the line length, and and subject line hopefully it goes this time.


> On Jan 1, 2015, at 1:56 PM, Dan Smith <dsmith at danplanet.com> wrote:
> 
>>> I accept the criticism as its my first cut and I had troubles.
> 
> Definitely don't take offense -- code review is part of open source, and
> it's a good thing :)
> 
>>> Do I need to do anything about the issue number and line length or
>>> will you take care of that? Happy new year.
>> 
>> I'm just observing. Only Dan has commit privileges and he'll want
>> those things fixed before committing.
> 
> Yep, my scripts won't even allow it into the tree without a proper
> commit message that references the issue number with a # sign in front.
> With mq, it's really easy to amend a patch to make a few changes and
> resubmit.
> 
> Thanks!
> 
> --Dan
> 
> _______________________________________________
> chirp_devel mailing list
> chirp_devel at intrepid.danplanet.com
> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
> Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers




More information about the chirp_devel mailing list