[chirp_devel] patch issue 1353 TH9800 basic support

Dan Smith
Thu Jan 1 10:56:19 PST 2015


>> I accept the criticism as its my first cut and I had troubles.

Definitely don't take offense -- code review is part of open source, and
it's a good thing :)

>> Do I need to do anything about the issue number and line length or
>> will you take care of that? Happy new year.
> 
> I'm just observing. Only Dan has commit privileges and he'll want
> those things fixed before committing.

Yep, my scripts won't even allow it into the tree without a proper
commit message that references the issue number with a # sign in front.
With mq, it's really easy to amend a patch to make a few changes and
resubmit.

Thanks!

--Dan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
Url : http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20150101/88a549ea/attachment-0001.bin 


More information about the chirp_devel mailing list