[chirp_devel] [PATCH 2/4] Refactor version display into chirp module (#2343)

[Jens Jensen]

I think it's generally PEP8, but we haven't all been sticking to it (many of us were new to python when we started on this ;).
Althought I use vim all the time for chirp I mainly use sublime.This might be interesting:https://github.com/nvie/vim-flake8

also I want to look into flake8 ;)
      From: Zach Welch <zach at mandolincreekfarm.com>
 To: chirp_devel at intrepid.danplanet.com 
 Sent: Monday, February 23, 2015 10:43 PM
 Subject: Re: [chirp_devel] [PATCH 2/4] Refactor version display into chirp module (#2343)
   
On 02/23/2015 03:27 PM, Dan Smith wrote:
>>  if __name__ == "__main__":
>>      parser = OptionParser()
>> +        parser.add_option("", "--version", action="callback",
>> +                          callback=print_version, nargs=0,
>> +                          help="Print version and exit")
>
> Looks like you broke the indenting here. I know, Python is weird... :)

In my defense, it appears that the chirp.py indenting is inconsistent. 
My vim settings for this project expanded tabs, which I took to be the 
correct choice (as it appears to be the dominant style in the code). 
However, chirp.py contains lots of tabs, thus the mismatch apparent in 
the above hunk.

Assuming that spaces are to be preferred to tabs, I can create an 
additional patch to convert all tabs to spaces, giving the indentation 
the consistency that it needs.  More generally, does CHIRP have a style 
guide that I can reference?

Cheers,
-- 
Zach Welch
Mandolin Creek Farm
www.mandolincreekfarm.com
farm: 541-453-4131
cell: 541-740-3410
_______________________________________________
chirp_devel mailing list
chirp_devel at intrepid.danplanet.com
http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers


  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20150224/9759abaf/attachment-0001.html