<html><body><div style="color:#000; background-color:#fff; font-family:HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:16px"><div id="yui_3_16_0_1_1424787078388_4320" dir="ltr"><span id="yui_3_16_0_1_1424787078388_4335">I think it's generally PEP8, but we haven't all been sticking to it (many of us were new to python when we started on this ;).</span></div><div id="yui_3_16_0_1_1424787078388_4320" dir="ltr"><br></div><div id="yui_3_16_0_1_1424787078388_4320" dir="ltr">Althought I use vim all the time for chirp I mainly use sublime.</div><div id="yui_3_16_0_1_1424787078388_4320" dir="ltr">This might be interesting:</div><div id="yui_3_16_0_1_1424787078388_4320" dir="ltr"><a href="https://github.com/nvie/vim-flake8" id="yui_3_16_0_1_1424787078388_4380">https://github.com/nvie/vim-flake8</a><br></div><div id="yui_3_16_0_1_1424787078388_4320" dir="ltr"><br></div><div id="yui_3_16_0_1_1424787078388_4320" dir="ltr">also I want to look into flake8 ;)</div><div id="yui_3_16_0_1_1424787078388_4320" dir="ltr"><br></div> <div style="font-family: HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 16px;" id="yui_3_16_0_1_1424787078388_4317"> <div style="font-family: HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 16px;" id="yui_3_16_0_1_1424787078388_4316"> <div dir="ltr" id="yui_3_16_0_1_1424787078388_4315"> <hr size="1" id="yui_3_16_0_1_1424787078388_4362"> <font size="2" face="Arial" id="yui_3_16_0_1_1424787078388_4318"> <b><span style="font-weight:bold;">From:</span></b> Zach Welch <zach@mandolincreekfarm.com><br> <b><span style="font-weight: bold;">To:</span></b> chirp_devel@intrepid.danplanet.com <br> <b><span style="font-weight: bold;">Sent:</span></b> Monday, February 23, 2015 10:43 PM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [chirp_devel] [PATCH 2/4] Refactor version display into chirp module (#2343)<br> </font> </div> <div class="y_msg_container" id="yui_3_16_0_1_1424787078388_4319"><br>On 02/23/2015 03:27 PM, Dan Smith wrote:<br>>> if __name__ == "__main__":<br>>> parser = OptionParser()<br>>> + parser.add_option("", "--version", action="callback",<br>>> + callback=print_version, nargs=0,<br>>> + help="Print version and exit")<br>><br>> Looks like you broke the indenting here. I know, Python is weird... :)<br><br>In my defense, it appears that the chirp.py indenting is inconsistent. <br>My vim settings for this project expanded tabs, which I took to be the <br>correct choice (as it appears to be the dominant style in the code). <br>However, chirp.py contains lots of tabs, thus the mismatch apparent in <br>the above hunk.<br><br>Assuming that spaces are to be preferred to tabs, I can create an <br>additional patch to convert all tabs to spaces, giving the indentation <br>the consistency that it needs. More generally, does CHIRP have a style <br>guide that I can reference?<br><br>Cheers,<br>-- <br>Zach Welch<br>Mandolin Creek Farm<br>www.mandolincreekfarm.com<br>farm: 541-453-4131<br>cell: 541-740-3410<br>_______________________________________________<br>chirp_devel mailing list<br><a ymailto="mailto:chirp_devel@intrepid.danplanet.com" href="mailto:chirp_devel@intrepid.danplanet.com">chirp_devel@intrepid.danplanet.com</a><br><a href="http://intrepid.danplanet.com/mailman/listinfo/chirp_devel" target="_blank">http://intrepid.danplanet.com/mailman/listinfo/chirp_devel</a><br>Developer docs: <a href="http://chirp.danplanet.com/projects/chirp/wiki/Developers" target="_blank">http://chirp.danplanet.com/projects/chirp/wiki/Developers</a><br><br><br></div> </div> </div> </div></body></html>