[chirp_devel] [PATCH] [uv5r] add work mode settings

[Jim Unroe]

Sounds like a great idea to me. Let me see if I can figure out how to
resubmit it?

Also, would it be difficult to limit the 0-127 selection to only programmed
channels? Right now I depend on the user to select a programmed channel.
Choosing an empty channel defaults to the channel with the lowest number.
So it really isn't a big deal.
Jim

On Fri, Jan 18, 2013 at 8:45 PM, Dan Smith <dsmith at danplanet.com> wrote:

> Hey Jim,
>
> > +#seekto 0x0E7E;
> > +struct {
> > +  u8 mrcha;
> > +  u8 mrchb;
> > +} wmchannel;
>
> Since these channels can only be 0-127, I wonder if we ought to limit
> them appropriately? It's possible that the baofeng could use that upper
> bit for something, which would cause your parsing code below to blow
> up. Something like:
>
> struct {
>   u8 unused1:1,
>      mrcha:7;
>   u8 unused2:1,
>      mrchb:7;
> } wmchannel;
>
> The 7-bit field there fits perfectly and will avoid you crashing if
> that upper bit is set. What do you think?
>
> --
> Dan Smith
> www.danplanet.com
> KK7DS
>
> _______________________________________________
> chirp_devel mailing list
> chirp_devel at intrepid.danplanet.com
> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
> Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://intrepid.danplanet.com/pipermail/chirp_devel/attachments/20130118/e2137698/attachment-0001.html