Sounds like a great idea to me. Let me see if I can figure out how to resubmit it?<br><br>Also, would it be difficult to limit the 0-127 selection to only programmed channels? Right now I depend on the user to select a programmed channel. Choosing an empty channel defaults to the channel with the lowest number. So it really isn't a big deal.<br>
Jim<br><br><div class="gmail_quote">On Fri, Jan 18, 2013 at 8:45 PM, Dan Smith <span dir="ltr"><<a href="mailto:dsmith@danplanet.com" target="_blank">dsmith@danplanet.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hey Jim,<br>
<div class="im"><br>
> +#seekto 0x0E7E;<br>
> +struct {<br>
> + u8 mrcha;<br>
> + u8 mrchb;<br>
> +} wmchannel;<br>
<br>
</div>Since these channels can only be 0-127, I wonder if we ought to limit<br>
them appropriately? It's possible that the baofeng could use that upper<br>
bit for something, which would cause your parsing code below to blow<br>
up. Something like:<br>
<br>
struct {<br>
u8 unused1:1,<br>
mrcha:7;<br>
u8 unused2:1,<br>
mrchb:7;<br>
} wmchannel;<br>
<br>
The 7-bit field there fits perfectly and will avoid you crashing if<br>
that upper bit is set. What do you think?<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Dan Smith<br>
<a href="http://www.danplanet.com" target="_blank">www.danplanet.com</a><br>
KK7DS<br>
</font></span><br>_______________________________________________<br>
chirp_devel mailing list<br>
<a href="mailto:chirp_devel@intrepid.danplanet.com">chirp_devel@intrepid.danplanet.com</a><br>
<a href="http://intrepid.danplanet.com/mailman/listinfo/chirp_devel" target="_blank">http://intrepid.danplanet.com/mailman/listinfo/chirp_devel</a><br>
Developer docs: <a href="http://chirp.danplanet.com/projects/chirp/wiki/Developers" target="_blank">http://chirp.danplanet.com/projects/chirp/wiki/Developers</a><br></blockquote></div><br>