<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<pre class="moz-quote-pre" wrap="">Dan & Stuart (& Martin, below),
>> he argued that if your code was getting constrained to the right-hand edge (in his words "more than 3 levels of indentation"), your functions were probably getting too complex
</pre>
OK, I get that. I follow the rule of refactoring down to
"single-purpose" functions all the time. But, here's an example of a
function that can't get any simpler: It's only doing one thing
(repeatedly 9 times). It should only take (9 + overhead) lines of
code, but with PEP8 it gets spread out to 50 lines.<br>
<p><br>
</p>
<div style="color: #d6deeb;background-color: #000000;font-family: 'Cascadia Code', Consolas, 'Courier New', monospace;font-weight: normal;font-size: 12px;line-height: 16px;white-space: pre;"><div style="color: #d6deeb;background-color: #000000;font-family: 'Cascadia Code', Consolas, 'Courier New', monospace;font-weight: normal;font-size: 12px;line-height: 16px;white-space: pre;"><div><span style="color: #d6deeb;"> </span><span style="color: #c792ea;font-style: italic;">def</span><span style="color: #d6deeb;"> </span><span style="color: #82aaff;">interpret_extra_channel_data</span><span style="color: #d9f5dd;">(</span><span style="color: #7fdbca;">self</span><span style="color: #d6deeb;">, </span><span style="color: #7fdbca;">mem</span><span style="color: #d6deeb;">, </span><span style="color: #7fdbca;">_mem</span><span style="color: #d9f5dd;">)</span><span style="color: #d6deeb;">:</span></div><div><span style="color: #d6deeb;"> mem.extra </span><span style="color: #76aba8;">=</span><span style="color: #d6deeb;"> </span><span style="color: #b2ccd6;">RadioSettingGroup</span><span style="color: #d6deeb;">(</span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">Extra</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">extra</span><span style="color: #d9f5dd;">"</span><span style="color: #d6deeb;">)</span></div><div><span style="color: #d6deeb;"> mem.extra.</span><span style="color: #b2ccd6;">extend</span><span style="color: #d6deeb;">(</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">[</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSetting</span><span style="color: #d6deeb;">(</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">rev</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">Reverse</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSettingValueBoolean</span><span style="color: #d6deeb;">(</span><span style="color: #82aaff;">_mem.rev</span><span style="color: #d6deeb;">)</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d6deeb;">)</span><span style="color: #82aaff;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSetting</span><span style="color: #d6deeb;">(</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">compander</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">Compander</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSettingValueBoolean</span><span style="color: #d6deeb;">(</span><span style="color: #82aaff;">_mem.compander</span><span style="color: #d6deeb;">)</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d6deeb;">)</span><span style="color: #82aaff;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSetting</span><span style="color: #d6deeb;">(</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">talkaround</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">Talkaround</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSettingValueBoolean</span><span style="color: #d6deeb;">(</span><span style="color: #82aaff;">_mem.talkaround</span><span style="color: #d6deeb;">)</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d6deeb;">)</span><span style="color: #82aaff;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSetting</span><span style="color: #d6deeb;">(</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">pttid</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">PTT ID</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSettingValueList</span><span style="color: #d6deeb;">(</span></div><div><span style="color: #82aaff;"> </span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._PTT_IDS</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._PTT_IDS</span><span style="color: #d9f5dd;">[</span><span style="color: #82aaff;">_mem.pttid</span><span style="color: #d9f5dd;">]</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d6deeb;">)</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d6deeb;">)</span><span style="color: #82aaff;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSetting</span><span style="color: #d6deeb;">(</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">bclo</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">Busy Channel Lockout</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSettingValueList</span><span style="color: #d6deeb;">(</span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._BCLO</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._BCLO</span><span style="color: #d9f5dd;">[</span><span style="color: #82aaff;">_mem.bclo</span><span style="color: #d9f5dd;">]</span><span style="color: #d6deeb;">)</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d6deeb;">)</span><span style="color: #82aaff;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSetting</span><span style="color: #d6deeb;">(</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">optsig</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">Optional Signaling</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSettingValueList</span><span style="color: #d6deeb;">(</span></div><div><span style="color: #82aaff;"> </span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._OPT_SIGS</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._OPT_SIGS</span><span style="color: #d9f5dd;">[</span><span style="color: #82aaff;">_mem.optsig</span><span style="color: #d9f5dd;">]</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d6deeb;">)</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d6deeb;">)</span><span style="color: #82aaff;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSetting</span><span style="color: #d6deeb;">(</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">dtmfSlotNum</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">DTMF</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSettingValueList</span><span style="color: #d6deeb;">(</span></div><div><span style="color: #82aaff;"> </span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._DTMF_SLOTS</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._DTMF_SLOTS</span><span style="color: #d9f5dd;">[</span><span style="color: #82aaff;">_mem.dtmfSlotNum</span><span style="color: #d9f5dd;">]</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d6deeb;">)</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d6deeb;">)</span><span style="color: #82aaff;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSetting</span><span style="color: #d6deeb;">(</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">twotone</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">2-Tone</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSettingValueList</span><span style="color: #d6deeb;">(</span></div><div><span style="color: #82aaff;"> </span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._TONE2_SLOTS</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._TONE2_SLOTS</span><span style="color: #d9f5dd;">[</span><span style="color: #82aaff;">_mem.twotone</span><span style="color: #d9f5dd;">]</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d6deeb;">)</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d6deeb;">)</span><span style="color: #82aaff;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSetting</span><span style="color: #d6deeb;">(</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">fivetone</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">5-Tone</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSettingValueList</span><span style="color: #d6deeb;">(</span></div><div><span style="color: #82aaff;"> </span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._TONE5_SLOTS</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._TONE5_SLOTS</span><span style="color: #d9f5dd;">[</span><span style="color: #82aaff;">_mem.fivetone</span><span style="color: #d9f5dd;">]</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d6deeb;">)</span><span style="color: #d9f5dd;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d6deeb;">)</span><span style="color: #82aaff;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">]</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d6deeb;">)</span></div><div><span style="color: #d6deeb;">
</span></div></div></div>
<p></p>
<p>vs. this version with a 132 char line limit:<br>
</p>
<div style="color: #d6deeb;background-color: #000000;font-family: 'Cascadia Code', Consolas, 'Courier New', monospace;font-weight: normal;font-size: 12px;line-height: 16px;white-space: pre;"><div><span style="color: #d6deeb;"> </span><span style="color: #c792ea;font-style: italic;">def</span><span style="color: #d6deeb;"> </span><span style="color: #82aaff;">interpret_extra_channel_data</span><span style="color: #d9f5dd;">(</span><span style="color: #7fdbca;">self</span><span style="color: #d6deeb;">, </span><span style="color: #7fdbca;">mem</span><span style="color: #d6deeb;">, </span><span style="color: #7fdbca;">_mem</span><span style="color: #d9f5dd;">)</span><span style="color: #d6deeb;">:</span></div><div><span style="color: #d6deeb;"> mem.extra </span><span style="color: #76aba8;">=</span><span style="color: #d6deeb;"> </span><span style="color: #b2ccd6;">RadioSettingGroup</span><span style="color: #d6deeb;">(</span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">Extra</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">extra</span><span style="color: #d9f5dd;">"</span><span style="color: #d6deeb;">)</span></div><div><span style="color: #d6deeb;"> mem.extra.</span><span style="color: #b2ccd6;">extend</span><span style="color: #d6deeb;">(</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">[</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSetting</span><span style="color: #d6deeb;">(</span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">rev</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">Reverse</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSettingValueBoolean</span><span style="color: #d6deeb;">(</span><span style="color: #82aaff;">_mem.rev</span><span style="color: #d6deeb;">))</span><span style="color: #82aaff;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSetting</span><span style="color: #d6deeb;">(</span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">compander</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">Compander</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSettingValueBoolean</span><span style="color: #d6deeb;">(</span><span style="color: #82aaff;">_mem.compander</span><span style="color: #d6deeb;">))</span><span style="color: #82aaff;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSetting</span><span style="color: #d6deeb;">(</span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">talkaround</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">Talkaround</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSettingValueBoolean</span><span style="color: #d6deeb;">(</span><span style="color: #82aaff;">_mem.talkaround</span><span style="color: #d6deeb;">))</span><span style="color: #82aaff;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSetting</span><span style="color: #d6deeb;">(</span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">pttid</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">PTT ID</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSettingValueList</span><span style="color: #d6deeb;">(</span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._PTT_IDS</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._PTT_IDS</span><span style="color: #d9f5dd;">[</span><span style="color: #82aaff;">_mem.pttid</span><span style="color: #d9f5dd;">]</span><span style="color: #d6deeb;">))</span><span style="color: #82aaff;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSetting</span><span style="color: #d6deeb;">(</span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">bclo</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">Busy Channel Lockout</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSettingValueList</span><span style="color: #d6deeb;">(</span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._BCLO</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._BCLO</span><span style="color: #d9f5dd;">[</span><span style="color: #82aaff;">_mem.bclo</span><span style="color: #d9f5dd;">]</span><span style="color: #d6deeb;">))</span><span style="color: #82aaff;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSetting</span><span style="color: #d6deeb;">(</span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">optsig</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">Optional Signaling</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSettingValueList</span><span style="color: #d6deeb;">(</span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._OPT_SIGS</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._OPT_SIGS</span><span style="color: #d9f5dd;">[</span><span style="color: #82aaff;">_mem.optsig</span><span style="color: #d9f5dd;">]</span><span style="color: #d6deeb;">))</span><span style="color: #82aaff;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSetting</span><span style="color: #d6deeb;">(</span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">dtmfSlotNum</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">DTMF</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSettingValueList</span><span style="color: #d6deeb;">(</span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._DTMF_SLOTS</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._DTMF_SLOTS</span><span style="color: #d9f5dd;">[</span><span style="color: #82aaff;">_mem.dtmfSlotNum</span><span style="color: #d9f5dd;">]</span><span style="color: #d6deeb;">))</span><span style="color: #82aaff;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSetting</span><span style="color: #d6deeb;">(</span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">twotone</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">2-Tone</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSettingValueList</span><span style="color: #d6deeb;">(</span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._TONE2_SLOTS</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._TONE2_SLOTS</span><span style="color: #d9f5dd;">[</span><span style="color: #82aaff;">_mem.twotone</span><span style="color: #d9f5dd;">]</span><span style="color: #d6deeb;">))</span><span style="color: #82aaff;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSetting</span><span style="color: #d6deeb;">(</span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">fivetone</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">"</span><span style="color: #ecc48d;">5-Tone</span><span style="color: #d9f5dd;">"</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #b2ccd6;">RadioSettingValueList</span><span style="color: #d6deeb;">(</span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._TONE5_SLOTS</span><span style="color: #d9f5dd;">,</span><span style="color: #82aaff;"> </span><span style="color: #8eace3;">self</span><span style="color: #82aaff;">._TONE5_SLOTS</span><span style="color: #d9f5dd;">[</span><span style="color: #82aaff;">_mem.fivetone</span><span style="color: #d9f5dd;">]</span><span style="color: #d6deeb;">))</span><span style="color: #82aaff;">,</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d9f5dd;">]</span></div><div><span style="color: #82aaff;"> </span><span style="color: #d6deeb;">)</span></div></div>
<p></p>
<p>That cuts it down to 15 lines. This is much, much easier to read.
It only takes a split second to understand that "it's just a block
of settings." The 50-line version takes way longer to inspect
before you can see that there's nothing special about any of the 9
settings.</p>
<p>Martin and Stuart,<br>
</p>
<p>>> side-by-side viewing </p>
<p>I would also argue that even then, it's more important to
preserve vertical real estate than horizontal. When all you can
see within 50 physical lines is 9 logical lines of code, you
easily lose track of where you are in the grand scheme of things.
Sticking to this one simple example, say that someone added six
more RadioSetting calls to this function and moved the Compander
setting to the bottom because it logically goes together with one
of the new settings. With one line per call, you'd spot the
difference immediately in a side-by-side. With 15 calls spread
across 80 lines, you wouldn't.<br>
</p>
<p>I'm just say'n, it's been 50 years since the world went from
80-character teletypes to 132-character line printers and I, for
one, never looked back. <br>
</p>
<p>Anyway, If you can't see your way to 132 much less 160, I'll take
whatever I can get. Do I hear 100? Hell, I'd even take 90. I lost
count of how many comments I've written in the last few days that
had to be continued to the next line because of just one word.<br>
</p>
<p>(Dan, I saw your "not interested" declaration. Please know that
I'm not in the habit of beating a dead horse, so this will be my
last post on the subject, and I'll certainly respect your final
decision. I'll get back to work now. Thanks for listening.)<br>
</p>
<br>
<div id="DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2"><br /><table style="border-top: 1px solid #D3D4DE;"><tr><td style="width: 55px; padding-top: 13px;"><a href="http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient" target="_blank"><img src="https://s-install.avcdn.net/ipm/preview/icons/icon-envelope-tick-green-avg-v1.png" alt="" width="46" height="29" style="width: 46px; height: 29px;"/></a></td><td style="width: 470px; padding-top: 12px; color: #41424e; font-size: 13px; font-family: Arial, Helvetica, sans-serif; line-height: 18px;">Virus-free.<a href="http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient" target="_blank" style="color: #4453ea;">www.avg.com</a></td></tr></table><a href="#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2" width="1" height="1"> </a></div></body>
</html>