<div dir="ltr">Hello Chirp-Devel,<div><br></div><div>Attached is an update patch that should be used in place of the original one I submitted in this thread for the KG-UV920P-A. This patch implements suggestions from Jim Unroe on top of my original one. If there are any other issues, please let me know.</div><div><br></div><div>Thanks,<br>Matt</div><div>KF7TAL</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Feb 15, 2022 at 11:09 AM Matthew Handley <<a href="mailto:kf7tal@gmail.com" target="_blank">kf7tal@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi Jim,<div><br></div><div>Thank you for the feedback. If you're able to test this against your own KG-UV920P-A, that would be great.</div><div><br></div><div>Unless I hear otherwise, I'll create a new patch with those two corrections when I have a chance this evening. Would the convention be to share it in this same email thread, or start a new one?</div><div><br></div><div>Thanks,</div><div>Matt</div><div>KF7TAL</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Feb 14, 2022 at 7:59 AM Jim Unroe <<a href="mailto:rock.unroe@gmail.com" target="_blank">rock.unroe@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Matthew and Chirp-Devel,<br>
<br>
Nice! Thank you for developing this driver. I am going to try to find<br>
time today to dig my Wouxun KG-UV920P-A out of mothballs and give this<br>
a go. It looks great!<br>
<br>
Below are a couple of things that you might have to address before it<br>
gets accepted (unless Dan takes care of it for you):<br>
<br>
1. I think it was requested that the commit message be broken up into<br>
lines of less than 80 characters. I could be wrong but something got<br>
me into the habit of doing it. ;-)<br>
<br>
2. I don't see where the driver was added to the cpep8.manifest. It<br>
needs to be listed in the manifest so that the build system will know<br>
to perform a pep8 style check on it during the build process. The good<br>
news is that your driver passes the style check with flying colors.<br>
<br>
Thank you again for your work developing this driver.<br>
<br>
Jim KC9HI<br>
<br>
<br>
<br>
On Sun, Feb 13, 2022 at 9:46 PM Matthew Handley via chirp_devel<br>
<<a href="mailto:chirp_devel@intrepid.danplanet.com" target="_blank">chirp_devel@intrepid.danplanet.com</a>> wrote:<br>
><br>
><br>
> _______________________________________________<br>
> chirp_devel mailing list<br>
> <a href="mailto:chirp_devel@intrepid.danplanet.com" target="_blank">chirp_devel@intrepid.danplanet.com</a><br>
> <a href="http://intrepid.danplanet.com/mailman/listinfo/chirp_devel" rel="noreferrer" target="_blank">http://intrepid.danplanet.com/mailman/listinfo/chirp_devel</a><br>
> Developer docs: <a href="http://chirp.danplanet.com/projects/chirp/wiki/Developers" rel="noreferrer" target="_blank">http://chirp.danplanet.com/projects/chirp/wiki/Developers</a><br>
</blockquote></div>
</blockquote></div>