<div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 19 Nov 2020 at 20:30, Dan Smith via chirp_devel <<a href="mailto:chirp_devel@intrepid.danplanet.com">chirp_devel@intrepid.danplanet.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">> # HG changeset patch<br>
> # User Nicolas Pike <<a href="mailto:nicolas.jon.pike@gmail.com" target="_blank">nicolas.jon.pike@gmail.com</a>><br>
> # Date 1605379022 0<br>
> # Sat Nov 14 18:37:02 2020 +0000<br>
> # Node ID f0e565a301835f2358ca2842b22e8cfc708c796b<br>
> # Parent 98b8a850b0f136c77fe09a4922c32a2a28f708be<br>
> [senhaix_8800] New Model #7997<br>
> <br>
> diff -r 98b8a850b0f1 -r f0e565a30183 chirp/drivers/senhaix_8800.py<br>
> --- /dev/null Thu Jan 01 00:00:00 1970 +0000<br>
> +++ b/chirp/drivers/senhaix_8800.py Sat Nov 14 18:37:02 2020 +0000<br>
> @@ -0,0 +1,980 @@<br>
> +# Copyright 2020 Jiauxn Yang <<a href="mailto:jiaxun.yang@flygoat.com" target="_blank">jiaxun.yang@flygoat.com</a>><br>
<br>
Is this someone else's code? Obviously I can't accept someone else's copyrighted code without some indication that they intend it to be redistributed.<br>
<br></blockquote><div><a href="https://chirp.danplanet.com/issues/7997#change-28249">https://chirp.danplanet.com/issues/7997#change-28249</a><br></div><div>* The author is hospitalized at the moment. Hopefully on the mend. I have been helping test it and he asked me to submit it as per the issue page. </div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
> +@directory.register<br>
> +class SenHaiX8800Radio(chirp_common.CloneModeRadio):<br>
> + """SenHaiX 8800"""<br>
> + VENDOR = "SenHaiX"<br>
> + MODEL = "8800"<br>
<br>
I just want to check, especially because of the above: is this substantially similar to any other drivers in tree?<br></blockquote><div>* This driver should also work with the Radioddity gs-5b. I do not know how similar this driver may be to any others.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<br>
> + @classmethod<br>
> + def match_model(cls, filedata, filename):<br>
> + if len(filedata) in [MEM_SIZE]:<br>
> + return True<br>
> +<br>
> + return False<br>
<br>
New drivers shouldn't be adding these handlers, you can just rely on the automatic metadata-based matching method from here on out.<br>
* I would need to look into that, as up to this point I have only been testing the driver.<br></blockquote><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
Can you please provide a radio image so I can test this?<br>
* Please find attached a radio image.</blockquote><div><br></div><div>* Thanks</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
Thanks!<br>
<br>
--Dan<br>
_______________________________________________<br>
chirp_devel mailing list<br>
<a href="mailto:chirp_devel@intrepid.danplanet.com" target="_blank">chirp_devel@intrepid.danplanet.com</a><br>
<a href="http://intrepid.danplanet.com/mailman/listinfo/chirp_devel" rel="noreferrer" target="_blank">http://intrepid.danplanet.com/mailman/listinfo/chirp_devel</a><br>
Developer docs: <a href="http://chirp.danplanet.com/projects/chirp/wiki/Developers" rel="noreferrer" target="_blank">http://chirp.danplanet.com/projects/chirp/wiki/Developers</a><br>
</blockquote></div></div></div></div>