<div dir="ltr"><div>Sorry about my tersness. The last thing you need at this point is to be distracted from the py3 work.</div><div><br></div><div>I submitted the memedit.py patch as a standalone instead of part of my RO channel patch because I know you prefer simple standalone patches where possible, and for good reason.</div><div><br></div><div>The problem is that I added TX Frequency validation to the validate_memory method of my driver. After failing using other approaches, I went back to a March 14 e-mail on the devel list where Jim Unroe pointed me at gmrs_uv1.py. He extends the validate_memory method. I did the same for my new code. The problem is that that the mem structure passed to validate_memory is not the same as the one later passed to mem_set: Specifically, If the "duplex" field is "off" in the UI column, mem.duplex is set to "" when it reaches validate_memory. If it is "split" in the UI column, it gets changed in some other way that makes it different from what is passed to set_memory. I looked for and failed to find the spot where the value is changed back to "off" or "split".</div><div><br></div><div>Without this change, My modifed driver rejects an RO channel (i.e., one that has duplex "off") that has a frequency that is invalid for TX, and the UI "duplex" column is forced back to "". With this change, my driver works.</div><div><br></div><div>I have not yet looked at the py3 branch, but I will after I get this patch into the main branch.</div><div><br></div><div>How would you like me to provide the modified driver for your testing? Just as a patch in the usual manner? No new image is needed.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 27, 2019 at 6:53 AM Dan Smith via chirp_devel <<a href="mailto:chirp_devel@intrepid.danplanet.com">chirp_devel@intrepid.danplanet.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> # HG changeset patch<br>
> # User DanClemmensen <<a href="mailto:DanClemmensen@gmail.com" target="_blank">DanClemmensen@gmail.com</a>><br>
> # Date 1553532256 25200<br>
> # Mon Mar 25 09:44:16 2019 -0700<br>
> # Node ID 034168b01eceb10301f04dd8596c03aa1267099f<br>
> # Parent 936bffe5c76c85e7dd626c448b0e9031d274235c<br>
> [ft4] allow validation of RO frequencies [#6615]<br>
> Fixes: #6615<br>
> This change to the UI does not implement any RO changes. It<br>
> permits a river to implement such a change.<br>
> <br>
> diff -r 936bffe5c76c -r 034168b01ece chirp/ui/memedit.py<br>
> --- a/chirp/ui/memedit.py Tue Mar 19 12:58:02 2019 -0700<br>
> +++ b/chirp/ui/memedit.py Mon Mar 25 09:44:16 2019 -0700<br>
> @@ -137,6 +137,9 @@<br>
> was_filled, prev = self.store.get(iter, self.col("_filled"), colnum)<br>
> <br>
> def set_offset(offset):<br>
> + old_dup = self.store.get(iter, self.col(_("Duplex")))[0]<br>
> + if old_dup in ["off", "split"]:<br>
> + return<br>
> if offset > 0:<br>
> dup = "+"<br>
> elif offset == 0:<br>
<br>
I'm confused about what you're trying to do here, and having basically no explanation in the commit message isn't helping. I've read the bug and the reason for re-opening it, but I'm not sure what behavior you're describing. If I use the UV-5R driver, I can set a memory to "off" and it stays that way.<br>
<br>
Can you please describe what you're fixing and why? If I have to use your driver and test image to reproduce, please put steps in the bug or something.<br>
<br>
--Dan<br>
<br>
_______________________________________________<br>
chirp_devel mailing list<br>
<a href="mailto:chirp_devel@intrepid.danplanet.com" target="_blank">chirp_devel@intrepid.danplanet.com</a><br>
<a href="http://intrepid.danplanet.com/mailman/listinfo/chirp_devel" rel="noreferrer" target="_blank">http://intrepid.danplanet.com/mailman/listinfo/chirp_devel</a><br>
Developer docs: <a href="http://chirp.danplanet.com/projects/chirp/wiki/Developers" rel="noreferrer" target="_blank">http://chirp.danplanet.com/projects/chirp/wiki/Developers</a><br>
</blockquote></div>