<div dir="ltr"><div>I missed it in this patch, so I stuck it in the last patch when I reviewed your e-mail one last time. I am just</div><div>now beginning to understand the mq patch "stack" concept, so I now realize that I should have popped the</div><div>later patches, made this fix in the early patch, and then pushed the later patches back on the stack. I had not</div><div>figured that out.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 28, 2019 at 6:48 AM Dan Smith via chirp_devel <<a href="mailto:chirp_devel@intrepid.danplanet.com">chirp_devel@intrepid.danplanet.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> +def variable_len_resp(pipe):<br>
> + """<br>
> + when length of expected reply is not known, read byte at a time<br>
> + until the ack character is found.<br>
> + """<br>
> + response = b""<br>
> + i = 0<br>
> + toolong = 256 # arbitrary<br>
> + while True:<br>
> + b = pipe.read(1)<br>
> + if b == b'\x06':<br>
> + break<br>
> + else:<br>
> + response += b<br>
> + i += 1<br>
> + if i > toolong:<br>
> + LOG.debug("Response too long. got" + util.hexprint(response))<br>
> + raise errors.RadioError("Response too long.")<br>
<br>
Did you have a response to my comments in this part of the first patch?<br>
<br>
--Dan<br>
_______________________________________________<br>
chirp_devel mailing list<br>
<a href="mailto:chirp_devel@intrepid.danplanet.com" target="_blank">chirp_devel@intrepid.danplanet.com</a><br>
<a href="http://intrepid.danplanet.com/mailman/listinfo/chirp_devel" rel="noreferrer" target="_blank">http://intrepid.danplanet.com/mailman/listinfo/chirp_devel</a><br>
Developer docs: <a href="http://chirp.danplanet.com/projects/chirp/wiki/Developers" rel="noreferrer" target="_blank">http://chirp.danplanet.com/projects/chirp/wiki/Developers</a><br>
</blockquote></div>