<div dir="ltr">give me another 30 minutes.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 28, 2019 at 8:54 AM Dan Smith via chirp_devel <<a href="mailto:chirp_devel@intrepid.danplanet.com">chirp_devel@intrepid.danplanet.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> > + "->Tone": ("R-TONE", None),<br>
> <br>
> I had a question about this in the previous patch.<br>
> <br>
> > + "Tone->Tone": ("TSQL", None)<br>
> > + }<br>
> <br>
> These are two mappings from the CHIRP definitions to the Yaesu definitions. Yaesu uses "TSQL" to mean "send and receive ctcss tones,<br>
> and the toned do jot need to be identical. thus we must map to "Yaesu TSQL" on both cases. I chose to use the name "TSQL" for to this<br>
> Yaseu value because it's in the Yasu documentation and it's what you see on the radio's screen. I could have renamed it in the ptyhon<br>
> code, but the other drivers seem to adhere to the manufacturer's documentation.<br>
> <br>
> Sinmilarly, Yaesu "R-TONE" is the name for "don't send a tone, but do receive a tone." The Yaseu name for reverse polarity tone squelch is "REV TN".<br>
<br>
Okay, to my skimming eyes, it looked like equating Tone->Tone with TSQL (chirp's definition) which is not right.<br>
<br>
> The code has substantially different requirements for the two tables, so Idon't think that there is a single table that is both comprehensible and<br>
> has simple lookups for both directions. a simplified table will complicate the code. I'll give this another try today.<br>
<br>
FWIW, I don't think that it's particularly comprehensible today, but more importantly, it's really hard to look at them and tell if they're doing the same (but inverted) translation.<br>
<br>
Maybe I should stew on it a little more and look deeper into how you're using these.<br>
<br>
--Dan<br>
_______________________________________________<br>
chirp_devel mailing list<br>
<a href="mailto:chirp_devel@intrepid.danplanet.com" target="_blank">chirp_devel@intrepid.danplanet.com</a><br>
<a href="http://intrepid.danplanet.com/mailman/listinfo/chirp_devel" rel="noreferrer" target="_blank">http://intrepid.danplanet.com/mailman/listinfo/chirp_devel</a><br>
Developer docs: <a href="http://chirp.danplanet.com/projects/chirp/wiki/Developers" rel="noreferrer" target="_blank">http://chirp.danplanet.com/projects/chirp/wiki/Developers</a><br>
</blockquote></div>