<div dir="ltr"><div>I'm a python newbie, working in a weird environment (Gentoo Linux). I could not run ./runtest in either my Pythom 2 repository (tip) or in my py3 branch repository. When I forced it on my python 2 repository by modifying the bash script to run python2, the test passed. Hmm. I'll wait for your patch.<br></div><div><br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Feb 16, 2019 at 12:43 PM Dan Smith via chirp_devel <<a href="mailto:chirp_devel@intrepid.danplanet.com">chirp_devel@intrepid.danplanet.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> The code looks only at ctone in that case because that's the way I (perhaps incorrectly) interpreted the description at :<br>
> <a href="https://chirp.danplanet.com/projects/chirp/wiki/DevelopersToneModes" rel="noreferrer" target="_blank">https://chirp.danplanet.com/projects/chirp/wiki/DevelopersToneModes</a><br>
> I'll fix it. How do you run the test manually?<br>
<br>
The command is the first line of the quoted failures from my last mail, but basically:<br>
<br>
$ cd tests<br>
$ ./run_tests -d Yaesu_FT-4XR<br>
<br>
> The version(?) string I get back is<br>
> b'IFT-35R\x00\x00V100\x00\x00\0x06'<br>
> This looks like it's generic for all radios that use the Yaseu ICU-35 cable, and that it has provisions for versioning.<br>
<br>
Hmm, well, I'd tend to do something with that. How about just making sure it starts with IFT-35R and if so, plow ahead?<br>
<br>
> There is also information in the radio's memory block 0. This looks like (perhaps) a radio software version.<br>
> If I fail out, it is possible to let the user decide to continue?<br>
<br>
No, but it's usually good to be conservative here. I would say log information about what you got and what you were expecting and then raise RadioError saying that the model appears incompatible. Then if someone files a bug about having a FT-4XR that should work but doesn't, we can go from there.<br>
<br>
I meant to say in the last email: Thanks a lot for caring about making it work on python3 as well :)<br>
<br>
I figured out the issue in the test runner and will get that pushed up soonish.<br>
<br>
Thanks!<br>
<br>
--Dan<br>
<br>
_______________________________________________<br>
chirp_devel mailing list<br>
<a href="mailto:chirp_devel@intrepid.danplanet.com" target="_blank">chirp_devel@intrepid.danplanet.com</a><br>
<a href="http://intrepid.danplanet.com/mailman/listinfo/chirp_devel" rel="noreferrer" target="_blank">http://intrepid.danplanet.com/mailman/listinfo/chirp_devel</a><br>
Developer docs: <a href="http://chirp.danplanet.com/projects/chirp/wiki/Developers" rel="noreferrer" target="_blank">http://chirp.danplanet.com/projects/chirp/wiki/Developers</a><br>
</blockquote></div>