<div dir="ltr">I noticed my changes to the FT-50 driver are in the tree now. However, my test image did not make it yet. I guess Dan needs to get that checked in so the driver is covered by the testing.<div><br></div><div>Also, someone can update the web page to indicate support for this model whenever you guys want.</div><div><br></div><div>Thanks for all the help!</div><div>-mark</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 15, 2016 at 5:26 PM, Mark Adams <span dir="ltr"><<a href="mailto:madams74@gmail.com" target="_blank">madams74@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Dan (& group),<div><br></div><div>Sorry it took me a couple of days to get back to you. I made some minor improvements including fixing a few pep8 issues and improving upload reliability. I think this is now ready to go into the tree.</div><div><br></div><div>This new patch completely replaces the first patch. It includes the removal of the ft50_II.py file this time.</div><div><br></div><div>Feel free to let me know if there are any issues.</div><div><br></div><div>Thanks,</div><div>-mark</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jan 9, 2016 at 8:39 PM, Dan Smith via chirp_devel <span dir="ltr"><<a href="mailto:chirp_devel@intrepid.danplanet.com" target="_blank">chirp_devel@intrepid.danplanet.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Mark,<br>
<br>
Sorry for the delayed response.<br>
<span><br>
> I've gotten enough completed on the FT-50 driver that I thought it was<br>
> time for a patch. I'd like some eyes on it to make sure I'm not doing<br>
> something really wrong or going in a bad direction.<br>
<br>
</span>I've had a quick skim and it seems fine to me. If it works, then I'd say<br>
we should put it in the tree and see how it goes. Any reservations from you?<br>
<span><br>
> NOTE: the chirp/drivers/ft50_ll.py file is no longer needed and should<br>
> be removed. I don't know how to include that change in the soft-commit<br>
> and patch.<br>
<br>
</span>What you did should be fine.<br>
<br>
Thanks!<br>
<br>
--Dan<br>
_______________________________________________<br>
chirp_devel mailing list<br>
<a href="mailto:chirp_devel@intrepid.danplanet.com" target="_blank">chirp_devel@intrepid.danplanet.com</a><br>
<a href="http://intrepid.danplanet.com/mailman/listinfo/chirp_devel" rel="noreferrer" target="_blank">http://intrepid.danplanet.com/mailman/listinfo/chirp_devel</a><br>
Developer docs: <a href="http://chirp.danplanet.com/projects/chirp/wiki/Developers" rel="noreferrer" target="_blank">http://chirp.danplanet.com/projects/chirp/wiki/Developers</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>