<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi to all.<br>
<br>
As you may noticed I'm developing a new driver for commercial
Kenwoods, see details in issue 2999 here:
<a class="moz-txt-link-freetext" href="http://chirp.danplanet.com/issues/2999">http://chirp.danplanet.com/issues/2999</a><br>
<br>
I just have completed the last milestone (full bank support, a lot
of bug fixes, a lot of validation, PEP8, and new settings) to send
the patch to the daily tree, and the code it's stable enough in my
testing bed here with 3 radios.<br>
<br>
But the <i>run_tests</i> script fails, digging around this I found
that the culprit is the run_test script it self in he section for
testing banks with newly created channels exactly in two places (so
far):<br>
<br>
<code><br>
{set memory empty}<br>
{assign some basic data to channel}<br>
mem_banks = model.get_memory_mappings(mem)<br>
if len(mem_banks) != 0:<br>
raise TestFailedError("Freshly-created memory has banks
and " +<br>
"should not", "Banks:
%s" % str(mem_banks))<br>
{.....}<br>
<br>
model.remove_memory_from_mapping(mem, banks[0])<br>
reason = verify(banks[0])<br>
if reason is None:<br>
raise TestFailedError("Memory remains in bank after
remove",<br>
reason)<br>
<br>
</code><br>
<br>
As you can see in this code segments this assume that <u>a channel
may be assigned to a bank <b>or not</b></u>, but then here come
this Kenwood commercial radios to break this:<br>
<br>
The Kenwood Radio Serie 60G family has a different paradigm:<br>
<br>
<b>A channel must belong to a </b><b>Channel</b><b> </b><b>Group
(aka bank) </b><b>always</b><br>
<br>
Then, should I patch the run_test.sh script to reproduce the desired
behavior?<br>
<br>
It's the less traumatic solution from my point of view, but the less
elegant.<br>
<br>
My python is improving but it's not enough to recreate a bank model
class with this enforcement link incluede, if such provision is made
we need to change also the <i>run_tests</i> script to reflect this
changes.<br>
<br>
As I'm new into this community I has to ask to the collective
intelligence: <br>
<br>
What is the correct solution to this?<br>
<br>
Cheers. <br>
</body>
</html>