<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body><div><div style="font-family: Calibri,sans-serif; font-size: 11pt;">Thanks!<br><br>Looks good and everything is working as it should then. I'm surprised I never noticed the duplicate none entry before.</div></div><div dir="ltr"><hr><span style="font-family: Calibri,sans-serif; font-size: 11pt; font-weight: bold;">From: </span><span style="font-family: Calibri,sans-serif; font-size: 11pt;"><a href="mailto:chirp_devel@intrepid.danplanet.com">Tom Hayward via chirp_devel</a></span><br><span style="font-family: Calibri,sans-serif; font-size: 11pt; font-weight: bold;">Sent: </span><span style="font-family: Calibri,sans-serif; font-size: 11pt;">10/7/2015 9:24 AM</span><br><span style="font-family: Calibri,sans-serif; font-size: 11pt; font-weight: bold;">To: </span><span style="font-family: Calibri,sans-serif; font-size: 11pt;"><a href="mailto:chirp_devel@intrepid.danplanet.com">chirp_devel@intrepid.danplanet.com</a></span><br><span style="font-family: Calibri,sans-serif; font-size: 11pt; font-weight: bold;">Subject: </span><span style="font-family: Calibri,sans-serif; font-size: 11pt;">Re: [chirp_devel] [PATCH 2 of 2] drivers/ft60: add support for"off"duplex mode (#2891)</span><br><br></div>On Tue, Oct 6, 2015 at 10:23 PM, Patrick Lang via chirp_devel<br><chirp_devel@intrepid.danplanet.com> wrote:<br>><br>> For CHIRP in general - does “off” mean:<br>><br>> a) duplex / repeater shift is disabled and the radio should operate in<br>> simplex mode<br>><br>> or<br>><br>> b) Tx is inhibited<br><br>It's, of course, "b":<br>http://chirp.danplanet.com/projects/chirp/wiki/MemoryEditorColumns#Duplex<br><br>> For issue 2891 – I think it would be cleaner to simply remove the extra “”<br>> from line 275, rather than stripping it from the array as its assigned to<br>> the rf object in line 367. Is the extra “”, “” needed in line 275 to<br>> effectively 1-index the duplex value instead? If not, it seems like we could<br>> just strip it out and assign the array as-is. This is how the VX-6 and most<br>> other drivers work.<br><br>Yes, the array index is important here.<br><br>Tom KD7LXL<br>_______________________________________________<br>chirp_devel mailing list<br>chirp_devel@intrepid.danplanet.com<br>http://intrepid.danplanet.com/mailman/listinfo/chirp_devel<br>Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers</body></html>