<div dir="ltr">Ok, I fixed the issue that was causing the unit test failures, and added the correct modes (tone, dtcs, cross, etc).<div>I ran the unit tests on two radio images, and they all passed. I also tested the patch with a radio and confirmed operation.</div><div><br></div><div>Review this patch again for inclusion in the chrip base.</div><div><br></div><div>I've included the test images that I used in the ticket (#1035), so you can include them in the test image corpus if you so chose. </div><div><br></div><div>thanks,</div><div><br></div><div>Dave kk6df</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, May 2, 2015 at 1:14 PM, Dan Smith <span dir="ltr"><<a href="mailto:dsmith@danplanet.com" target="_blank">dsmith@danplanet.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">> # HG changeset patch<br>
> # User David Fannin <<a href="mailto:dfannin@sushisoft.com">dfannin@sushisoft.com</a>><br>
> # Date 1430596915 25200<br>
> # Sat May 02 13:01:55 2015 -0700<br>
> # Node ID 9e5169ff126fe5bc82ce076e487898c91fd2c7b8<br>
> # Parent 31a7494c324a347634c30cc3c9bded2ce83eeb21<br>
> [Th9000] New model driver for TYT TH9000D radios - fixed base class #1035<br>
<br>
</span>Hi Dave, thanks for the respin. I was just going to apply this and when<br>
I ran it with the test image on the bug, I get this:<br>
<br>
> dan@eagle:~/dev/chirp/tests$ ./run_tests -d TYT_TH9000_144<br>
> TYT TH9000_144 Detect PASSED: All tests<br>
> TYT TH9000_144 Settings PASSED: All tests<br>
> TYT TH9000_144 Clone PASSED: All tests<br>
> TYT TH9000_144 Edges PASSED: All tests<br>
> TYT TH9000_144 BruteForce FAILED: Field `tmode' is `', expected `TSQL-R'<br>
> TYT TH9000_144 CopyAll PASSED: All tests<br>
> TYT TH9000_144 Banks SKIPPED: Banks not supported<br>
> ----------------------------------------------------------------------<br>
> Results:<br>
> TOTAL : 7<br>
> FAILED : 1<br>
> SKIPPED: 1<br>
> PASSED : 5<br>
> CRASHED: 0<br>
<br>
If I apply this with that failure, the build system won't be happy. Can<br>
you make sure that all the tests run for this driver before we apply it?<br>
Thanks!<br>
<span class="HOEnZb"><font color="#888888"><br>
--Dan<br>
<br>
</font></span><br>_______________________________________________<br>
chirp_devel mailing list<br>
<a href="mailto:chirp_devel@intrepid.danplanet.com">chirp_devel@intrepid.danplanet.com</a><br>
<a href="http://intrepid.danplanet.com/mailman/listinfo/chirp_devel" target="_blank">http://intrepid.danplanet.com/mailman/listinfo/chirp_devel</a><br>
Developer docs: <a href="http://chirp.danplanet.com/projects/chirp/wiki/Developers" target="_blank">http://chirp.danplanet.com/projects/chirp/wiki/Developers</a><br></blockquote></div><br></div>