<p dir="ltr">Was meant to, yes. I'll reroll an omnibus patch from tip when I get home tonight.</p>
<div class="gmail_quote">On Apr 6, 2015 3:43 PM, "Dan Smith" <<a href="mailto:dsmith@danplanet.com">dsmith@danplanet.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Charles,<br>
<br>
> Wrapped up the PEP-8 cleanups as much as possible. There was one where<br>
> it complained about under indenting, but that's nit picking to the<br>
> extreme. Caught a few minor issues as well in the process, too.<br>
<br>
Was this supposed to be a patch against your last patch? If so, I can't<br>
get this to apply cleanly against that.<br>
<br>
Either way, until your patch makes it into the tree, you should be<br>
sending patches rebased on current tip each time. A patch against a<br>
patch requires me to manually merge them to pass the checks.<br>
<br>
Could you maybe send a clean patch against current tip that adds the<br>
driver with everything passing the checks?<br>
<br>
Really looking forward to having this in the tree, as I know it's<br>
desired by a lot of folks. Thanks!<br>
<br>
--Dan<br>
<br>
<br>_______________________________________________<br>
chirp_devel mailing list<br>
<a href="mailto:chirp_devel@intrepid.danplanet.com">chirp_devel@intrepid.danplanet.com</a><br>
<a href="http://intrepid.danplanet.com/mailman/listinfo/chirp_devel" target="_blank">http://intrepid.danplanet.com/mailman/listinfo/chirp_devel</a><br>
Developer docs: <a href="http://chirp.danplanet.com/projects/chirp/wiki/Developers" target="_blank">http://chirp.danplanet.com/projects/chirp/wiki/Developers</a><br></blockquote></div>