<html><body><div style="color:#000; background-color:#fff; font-family:lucida console, sans-serif;font-size:10pt"><div><span>after looking at it a few times i _think_ i have it right…</span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: 'lucida console', sans-serif; background-color: transparent; font-style: normal;"><span><br></span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: 'lucida console', sans-serif; background-color: transparent; font-style: normal;"><span>the actual port open happens in between these statements</span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: 'lucida console', sans-serif; background-color: transparent;"><span>the <span style="font-style: italic;"><span>action of these statement</span>s</span> is to display the pre_upload prompt (<span style="font-weight: bold;">not</span> open port!)</span></div><div style="color: rgb(0, 0, 0); font-size: 13px;
font-family: 'lucida console', sans-serif; background-color: transparent; font-style: normal;"><span><br></span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: 'lucida console', sans-serif; background-color: transparent; font-style: normal;"><span style="text-decoration: underline;">so sequence is:</span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: 'lucida console', sans-serif; background-color: transparent;"><span>1. if open_port_before_upload_prompt is <span style="font-style: italic;">False</span>, then display pre_upload prompt</span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: 'lucida console', sans-serif; background-color: transparent;">2. open port</div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: 'lucida console', sans-serif; background-color: transparent;">3. if open_port_before_upload_prompt is <span style="font-style: italic;">True, </span>then display
pre_upload prompt</div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: 'lucida console', sans-serif; background-color: transparent; font-style: italic;"><br></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: 'lucida console', sans-serif; background-color: transparent;">At first glance it is sort of confusing, but the reasoning for this approach was because it was the most straightforward, minimalist way i could think to do this without revamping the entire section.</div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: 'lucida console', sans-serif; background-color: transparent;">(I just got the logic backwards - at least i think its right this time.)</div><div><br></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: 'lucida console', sans-serif; background-color: transparent; font-style: normal;">oh well, now that you got me thinking, perhaps the symbol name should be:</div><div
style="color: rgb(0, 0, 0); font-size: 13px; font-family: 'lucida console', sans-serif; background-color: transparent;"><span style="font-style: italic;">display_pre_upload_prompt_before_port_open</span><span style="font-style: normal;"> ?</span></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: 'lucida console', sans-serif; background-color: transparent; font-style: normal;">maybe this would make it more straightforward (albeit a bit verbose, which imho would be preferred for maintainability and comprehensibility).</div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: 'lucida console', sans-serif; background-color: transparent; font-style: normal;"><br></div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: 'lucida console', sans-serif; background-color: transparent; font-style: normal;">Have you already committed the related previous patch?</div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family:
'lucida console', sans-serif; background-color: transparent; font-style: normal;">Thoughts?</div><div style="color: rgb(0, 0, 0); font-size: 13px; font-family: 'lucida console', sans-serif; background-color: transparent; font-style: normal;"><br></div> <div style="font-family: 'lucida console', sans-serif; font-size: 10pt;"> <div style="font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande', sans-serif; font-size: 12pt;"> <div dir="ltr"> <hr size="1"> <font size="2" face="Arial"> <b><span style="font-weight:bold;">From:</span></b> Dan Smith <dsmith@danplanet.com><br> <b><span style="font-weight: bold;">To:</span></b> chirp_devel@intrepid.danplanet.com <br> <b><span style="font-weight: bold;">Sent:</span></b> Wednesday, February 5, 2014 6:50 PM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [chirp_devel] [PATCH] fix bad cable errors for some users on upload #1397 (2)<br> </font> </div> <div
class="y_msg_container"><br>> -<br clear="none">> - if prompts.open_port_before_upload_prompt == True:<br clear="none">> - print "Opening port before pre_upload prompt."<br clear="none">> + <br clear="none">> + if prompts.open_port_before_upload_prompt == False:<br clear="none">> + print "Opening port after pre_upload prompt."<br clear="none">> self._show_instructions(radio, prompts.pre_upload)<br clear="none"><br clear="none">I'm confused. This looks wrong to me. "If open_before is False, then<br clear="none">open (before)"<div class="yqt8273531678" id="yqtfd83761"><br clear="none"><br clear="none">> - if prompts.open_port_before_upload_prompt == False:<br clear="none">> -
print "Opening port after pre_upload prompt."<br clear="none">> + if prompts.open_port_before_upload_prompt == True:<br clear="none">> + print "Opening port before pre_upload prompt."<br clear="none">> self._show_instructions(radio, prompts.pre_upload)</div><br clear="none"><br clear="none">"If open_before is true, then open (after)".<br clear="none"><br clear="none">Didn't you have it right the first time?<br clear="none"><br clear="none">--Dan<div class="yqt8273531678" id="yqtfd88368"><br clear="none"></div><br><div class="yqt8273531678" id="yqtfd12549">_______________________________________________<br clear="none">chirp_devel mailing list<br clear="none"><a shape="rect" ymailto="mailto:chirp_devel@intrepid.danplanet.com"
href="mailto:chirp_devel@intrepid.danplanet.com">chirp_devel@intrepid.danplanet.com</a><br clear="none"><a shape="rect" href="http://intrepid.danplanet.com/mailman/listinfo/chirp_devel" target="_blank">http://intrepid.danplanet.com/mailman/listinfo/chirp_devel</a><br clear="none">Developer docs: <a shape="rect" href="http://chirp.danplanet.com/projects/chirp/wiki/Developers" target="_blank">http://chirp.danplanet.com/projects/chirp/wiki/Developers</a></div><br><br></div> </div> </div> </div></body></html>