<html><body><div style="color:#000; background-color:#fff; font-family:tahoma, new york, times, serif;font-size:12pt"><div><span>Ok, thanks for pointers on type consistency in the steps list. (I missed your point from an earlier email.)</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: tahoma,new york,times,serif; background-color: transparent; font-style: normal;"><span>No good reason other than than being new to python development ;)</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: tahoma,new york,times,serif; background-color: transparent; font-style: normal;"><span><br></span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: tahoma,new york,times,serif; background-color: transparent; font-style: normal;"><span>I would point out in the spirit of constructive criticism, that a. there is some inconsistency in this and other regards amongst various modules, and b. there is a lack clear
developer documentation on style (such as "please follow PEP8 when reasonable") guidelines, and project-level conventions, etc.</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: tahoma,new york,times,serif; background-color: transparent; font-style: normal;">I do understand the need for consistency, and that this is a community project, so that's why I would suggest some and even be willing to help with this on the twiki (although my available time is about to plummet due to school semester starting).</div><br>With all of that aside, changes made - please review latest version of the patch.<br>:)<br>Jens<br><br><div style="font-family: tahoma, new york, times, serif; font-size: 12pt;"> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div dir="ltr"> <hr size="1"> <font face="Arial" size="2"> <b><span style="font-weight:bold;">From:</span></b> Dan Smith <dsmith@danplanet.com><br>
<b><span style="font-weight: bold;">To:</span></b> chirp_devel@intrepid.danplanet.com <br> <b><span style="font-weight: bold;">Sent:</span></b> Monday, August 26, 2013 9:34 AM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [chirp_devel] [FT-90] add initial support for FT-90R. #1087<br> </font> </div> <div class="y_msg_container"><br>> + STEPS = [5, 10, 12.5, 15, 20, 25, 50]<br><br>While I understand this works, it's not what the other drivers do.<br>Please make these floats:<br><br> STEPS = [5.0, 10.0, ...]<br><br>Just for consistency, if you don't mind.<br><br>> + MODES = ["AM", "FM", "Auto"]<br>> + TMODES = ["", "Tone", "TSQL", "", "DTCS"] # idx 3 (Bell) not ...<br>> + TONES = list(chirp_common.TONES)<br>> + for tone in [ 165.5, 171.3, 177.3 ]:<br>> + TONES.remove(tone) <br>>
+ POWER_LEVELS = ["Hi", "Mid1", "Mid2", "Low"]<br>> + DUPLEX = ["", "-", "+", "split"]<br>> + mem_format = """<br><br>Sorry, I didn't notice this before, but I would really prefer that these<br>be module-level and not public class-level variables. Is there some<br>reason you moved these into the class, contrary to the pattern used<br>everywhere else? Class variables with mutable types are pretty<br>dangerous in Python...<br><br>I'm not trying to be overly pedantic here, just trying to keep<br>consistency with everything else. You're *really* close; thanks for<br>your work and patience on this :)<br><br>-- <br>Dan Smith<br>www.danplanet.com<br>KK7DS<br>_______________________________________________<br>chirp_devel mailing list<br><a ymailto="mailto:chirp_devel@intrepid.danplanet.com" href="mailto:chirp_devel@intrepid.danplanet.com">chirp_devel@intrepid.danplanet.com</a><br><a
href="http://intrepid.danplanet.com/mailman/listinfo/chirp_devel" target="_blank">http://intrepid.danplanet.com/mailman/listinfo/chirp_devel</a><br>Developer docs: <a href="http://chirp.danplanet.com/projects/chirp/wiki/Developers" target="_blank">http://chirp.danplanet.com/projects/chirp/wiki/Developers</a><br><br></div> </div> </div> </div></body></html>