<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Jul 10, 2013 at 7:50 PM, Dan Smith <span dir="ltr"><<a href="mailto:dsmith@danplanet.com" target="_blank">dsmith@danplanet.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">> + u8 rogerrx;<br>
> } settings[2];<br>
<br>
</div>We need to remove the legacy use of settings as an array. This is an<br>
artifact of a previous bug in bitwise which has since been fixed. Not<br>
your fault, but by knee-jerk reaction was that this addition would<br>
break the array :)<br></blockquote><div><br></div><div>I've always wondered why it was like this. But I try to leave things alone that I don't need to change because I don't want to break things.<br><br></div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im"><br>
> -TDRAB_LIST = ["Off", "A", "B"]<br>
> +TDRAB_LIST = ROGERRX_LIST = ["Off", "A", "B"]<br>
<br>
</div>This is a little confusing, I think we could just use the same list for<br>
both functions. But, I can't find anything else to complain about, so I<br>
won't ask you to change it.<br></blockquote><div><br></div><div>I originally tested it out using the same list for both functions. I didn't do it that way because I thought a "TDR" list being used for a "ROGER" function would be confusing. I supposed the list could have been renamed to something more generic.<br>
<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thanks! :)<br>
<span class="HOEnZb"></span><br></blockquote></div><br></div><div class="gmail_extra">Thank you for your help with getting us started. It's kind of neat adding a new radio without ever having touched one.<br><br></div>
<div class="gmail_extra">Jim<br></div></div>