<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Jul 3, 2013 at 7:48 PM, Dan Smith <span dir="ltr"><<a href="mailto:dsmith@danplanet.com" target="_blank">dsmith@danplanet.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Jim,<br>
<br>
Thanks for working on this, and sorry for the delay in responding.<br></blockquote><div><br></div><div>Sorry it took me so long to get my head around this. I thought some more about your guidance and suddenly woke up the other morning with a sense of knowing what I needed to do (I think).<br>
<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im"><br>
> def _do_upload(radio):<br>
> - _ident_radio(radio)<br>
> + ident = _ident_radio(radio)<br>
> + # VHF/UHF = "\x04" or "\x42" (original)<br>
> + # VHF/220 = "\x02"<br>
<br>
</div>Can you actually set these as constants at the top of the file, like<br>
STEPS, STEP_LIST, etc?<br></blockquote><div><br></div><div>Actually, these were just comments to show what I was looking for. So they are gone now. I really only need the one for VHF/220 so I made ...<br><br>vhf_220_radio = "\x02"<br>
<br></div><div>and put it just above STEPS<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im"><br>
> + radio_upper_band = ident[3:4]<br>
> + image_upper_band = _upper_band_from_image(radio)<br>
> +<br>
> + if image_upper_band == "\x02" or radio_upper_band == "\x02":<br>
<br>
</div>Then you can use those here instead of the raw hex, for more clarity.<br></blockquote><div><br></div><div>Done. There was one down near 'rf.valid_bands' too.<br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im"><br>
> + if image_upper_band != radio_upper_band:<br>
> + raise errors.RadioError("Image not supportted by radio")<br>
<br>
</div>"supported" is misspelled.<br></blockquote><div><br></div><div>Yeah. My tester caught that and I resubmitted a corrected patch earlier this morning. <br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thanks!<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Dan Smith<br>
<a href="http://www.danplanet.com" target="_blank">www.danplanet.com</a><br>
KK7DS<br>
</font></span><br></blockquote></div>Jim KC9HI<br></div></div>