<div dir="ltr">Hi,<div><br></div><div class="gmail_extra"><div class="gmail_quote">On Wed, Mar 13, 2013 at 2:33 PM, Dan Smith <span dir="ltr"><<a href="mailto:dsmith@danplanet.com" target="_blank">dsmith@danplanet.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">> If you drop self._config.get_bool("autorpt"), this reads:<br>
<br>
</div>I'm not sure why dropping it has any relevance, but perhaps you're just<br>
saying it reads oddly?<br></blockquote><div><br></div><div style>Sorry, yes, I meant that "new and changed" reads oddly.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">> + is_changed = new != prev if was_filled else True<br>
> + if new and is_changed:<br>
<br>
</div>How about we change it to:<br>
<div class="im"><br>
is_changed = new != prev if was_filled else True<br>
</div> autorpt_enabled = self._config.get_bool("autorpt")<br>
<br>
if new is not None and is_changed and autorpt_enabled:<br>
....<br></blockquote><div><br></div><div style>That looks good. Understanding that new is actually new_value makes the whole argument moot.</div></div><div><br></div>-- <br><div><span style="color:rgb(102,102,102)">Sean Burford <<a href="mailto:sburford@google.com" target="_blank">sburford@google.com</a>></span></div>
</div></div>