Dan<div><br></div><div><br></div><div>I am working in Windows which has no native diff program, I had to use "Exam Diff" and used the unix style output from it, which is why it is not your expected format.</div><div>
<br></div><div>I had a very quick look at your code, and wanted a quick and easy implementation for myself to use; certainly mods to the ID880 could make it work in a nicer programmatic manner. When I get the time I will try your diff. </div>
<div><br></div><div>I am sure there are lots of ic80ad owners that would appreciate their radio being supported.</div><div><br></div><div><br clear="all"><font color="#3333FF">Andrew Hart C.Eng. MRINA<br>amateur radio calls G8VTV / VE3NVK locator FN25bh<br>
<br>28, Chimo Drive, Kanata, ON, K2L 1A5 Canada<br><br>tel: 613 592 5043</font><br><div><br></div><div><font color="#FF0000">The content of this message is <b>NOT</b> intended for the public, and is a private communication.</font></div>
<div><font color="#FF0000" face="arial, sans-serif"><span style="border-collapse:collapse"><br></span></font></div><br>
<br><br><div class="gmail_quote">On 25 April 2011 21:01, Dan Smith <span dir="ltr"><<a href="mailto:dsmith@danplanet.com">dsmith@danplanet.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
> Below are three unix style diffs for the files mainapp.py, directory.py<br>
> and convert_ICF.py<br>
<br>
Typically patches are submitted in "unified format", which is generated<br>
by running "diff -u <orig> <new>". This makes them much easier to read<br>
and apply.<br>
<br>
> < class IC80ADRadio(icf.IcomCloneModeRadio, chirp_common.IcomDstarSupport):<br>
> ---<br>
> > class ID880Radio(icf.IcomCloneModeRadio, chirp_common.IcomDstarSupport):<br>
<br>
I think I've already got a suitable class (and model ID) at the bottom<br>
of id880.py, don't I? Looks like I never added it to the directory,<br>
which would explain why it doesn't work yet.<br>
<br>
I think that the following diff should suffice, right?<br>
<br>
diff -r 2abd55d12a72 chirp/directory.py<br>
--- a/chirp/directory.py Mon Apr 25 16:27:03 2011 -0700<br>
+++ b/chirp/directory.py Mon Apr 25 17:58:51 2011 -0700<br>
@@ -36,6 +36,7 @@<br>
"ic9x:B" : ic9x.IC9xRadioB,<br>
"id800" : id800.ID800v2Radio,<br>
"id880" : id880.ID880Radio,<br>
+ "id80" : id880.ID80Radio,<br>
"icx8x" : icx8x.ICx8xRadio,<br>
"idrpx000v" : idrp.IDRPx000V,<br>
"icq7" : icq7.ICQ7Radio,<br>
<br>
> Further, when downloading or uploading back into the radio the data rate<br>
> remains at 9600 and does not speed up as it appears it should, and as<br>
> does happen with the Icom programme. This means that the data transfer<br>
> takes several minutes with Chirp. Perhaps I missed something in the<br>
> code, as I did not take a great deal of time looking.<br>
<br>
Nope, I don't have the speed change implemented for anything other than<br>
the IC91/92AD (as it's required because they can be in either mode<br>
without notice).<br>
<br>
If the above diff works for you, I'll add it to the tree and we can<br>
claim ID80 support. Thanks!<br>
<font color="#888888"><br>
--<br>
Dan Smith<br>
<a href="http://www.danplanet.com" target="_blank">www.danplanet.com</a><br>
KK7DS<br>
_______________________________________________<br>
chirp_devel mailing list<br>
<a href="mailto:chirp_devel@intrepid.danplanet.com">chirp_devel@intrepid.danplanet.com</a><br>
<a href="http://intrepid.danplanet.com/mailman/listinfo/chirp_devel" target="_blank">http://intrepid.danplanet.com/mailman/listinfo/chirp_devel</a><br>
</font></blockquote></div><br></div>