[chirp_devel] Is it ok to remove SETTING_LISTS from all drivers?

Daniele Forsi
Mon Jun 5 14:38:17 PDT 2023


Hello,

The flake8 tool detects duplicate keys in the SETTING_LISTS dictionary
in some drivers, however  those drivers don't use that dictionary and
use the different values by checking the model of the radio. That
dictionary doesn't seem to be used by any driver. The tests still pass
after removing it.

Is it ok to remove SETTING_LISTS from all drivers?

This is the list of duplicate dictionary keys:
./chirp/drivers/retevis_rt21.py:562:5: F601 dictionary key 'cdcss'
repeated with different values
./chirp/drivers/retevis_rt21.py:563:5: F601 dictionary key 'cdcss'
repeated with different values
./chirp/drivers/retevis_rt21.py:578:5: F601 dictionary key 'voice'
repeated with different values
./chirp/drivers/retevis_rt21.py:579:5: F601 dictionary key 'voice'
repeated with different values
./chirp/drivers/retevis_rt21.py:580:5: F601 dictionary key 'voice'
repeated with different values

./chirp/drivers/radtel_t18.py:195:5: F601 dictionary key 'sidekey2'
repeated with different values
./chirp/drivers/radtel_t18.py:196:5: F601 dictionary key 'sidekey2'
repeated with different values
./chirp/drivers/radtel_t18.py:197:5: F601 dictionary key 'sidekey2'
repeated with different values
./chirp/drivers/radtel_t18.py:198:5: F601 dictionary key 'sidekey2'
repeated with different values
./chirp/drivers/radtel_t18.py:200:5: F601 dictionary key 'sidekey2S'
repeated with different values
./chirp/drivers/radtel_t18.py:201:5: F601 dictionary key 'sidekey2S'
repeated with different values

./chirp/drivers/bf_t8.py:123:5: F601 dictionary key 'tot' repeated
with different values
./chirp/drivers/bf_t8.py:124:5: F601 dictionary key 'tot' repeated
with different values
-- 
73 de IU5HKX Daniele



More information about the chirp_devel mailing list