[chirp_devel] [PATCH] [tg_uv2p] Inhibit keypad lock when in dual watch or crossmode. Fixes forth issue in #9939

[Dan Smith]

> [tg_uv2p] Inhibit keypad lock when in dual watch or crossmode. Fixes forth issue in #9939
> This is a radio feature when using the keypad :keypad lock cannot be applied
> (or releaswed) when in the above modes, now chirp behaves similarly.

Can you explain exactly what you're trying to accomplish here? It looks to me like you're depending on the order in which a bunch of settings are applied, and are stashing the value of one setting so the behavior of another one can be altered. That's fragile and won't work if the settings are reordered anywhere through the process. If you really need to do this, I think you should examine the state of the setting, either in the settings list or in the memobj.

I'm not sure what the radio behavior here is, but I think you're saying that when in dual-watch, the radio won't let you set the keylock enabled, is that right? If so, I think the better behavior is to reject the setting if it's invalid. So if keylock is enabled, refuse to allow setting DW. And if DW is enabled, refuse the allow setting keylock. Otherwise I suspect the UI is going to get out of sync with reality.

--Dan