[chirp_devel] [PATCH] Prevent spuriour error messages in memory editor while editing memories. Fixes #9381

Jim Unroe
Sat Sep 18 19:59:13 PDT 2021


I gave this a little workout. I didn't appear to have any issues
programming any of the available columns. The patch definitely
eliminated the "Error setting memory: Frequency 0.000000 is out of
supported range" that is always experienced when the Frequency field
of an empty memory row is accidentally double-clicked.

Jim KC9HI

On Sat, Sep 18, 2021 at 2:24 PM Dan Smith via chirp_devel
<chirp_devel at intrepid.danplanet.com> wrote:
>
> Hi Kosta,
>
> > # HG changeset patch
> > # User Kosta A. <ve7kcy at gmail.com>
> > # Date 1631945611 25200
> > #      Fri Sep 17 23:13:31 2021 -0700
> > # Branch mem-edit
> > # Node ID 0e72d226d24784ced8aecb55362052551f0c1c06
> > # Parent  9c47d5fc9f51d9b303f5e6ac539db05767c71880
> > Prevent spuriour error messages in memory editor while editing memories.  Fixes #9381.
> >
> > The memory editor has historically excluded the Frequency column from validating checks to determine if/when a value has changed for the previously noted reason in the code comment.  This change attempts to resolve this by caching all column values prior to finalizing the editing and restores the values in the case validation determines nothing has changed or the new contents have failed radio verification.
>
> Thanks for this. I don't have time to test this thoroughly at the moment, so I'm going to hold off on applying it just yet (but it's in the queue). If someone else could put it through its paces a little that would be a great data point.
>
> Thanks!
>
> --Dan
>
> _______________________________________________
> chirp_devel mailing list
> chirp_devel at intrepid.danplanet.com
> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
> Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers



More information about the chirp_devel mailing list