[chirp_devel] To Jim & James re #8747 TYT TH-UV88 Duplex Split memories
Jim Unroe
Mon Feb 1 10:35:28 PST 2021
Hi Rudolph,
It looks good to me. The only thing I would suggest would be to move
the "(none)" selection from the last position in the list to the first
position in the list to be consistent with most other CHIRP driver
modules.
>From this...
["-", "+", "split", "off", ""]
To this...
["", "-", "+", "split", "off"]
Jim KC9HI
On Thu, Jan 28, 2021 at 4:34 PM Rudolph Gutzerhagen via chirp_devel
<chirp_devel at intrepid.danplanet.com> wrote:
>
> to: Jim Unroe and James Berry
>
> would appreciate your code review on this small change to the driver you guys put together. It's my first one. Essentially I looked at the UV5R driver code and did the monkey-see monkey-doo modifications as part of learning how you put this stuff together. I tested it and it seems to work to my expectations, but without fully understanding the entire code in this section, I'm hesitant to just push it forward. Are there other considerations?
>
> Thanks in advance.
>
> and yes, the <RG: ToDo:> code markings are temporary.
> .
>
>
> _______________________________________________
> chirp_devel mailing list
> chirp_devel at intrepid.danplanet.com
> http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
> Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers
More information about the chirp_devel
mailing list