[chirp_devel] [PATCH] [AnyTone 5888UV] Add limited squelch mode & fix file identifier

Brad & Cindy Schuler
Thu Nov 19 17:48:12 PST 2020


Understood.

I think, though that I'm stuck.  I've submitted two patches for the anytone.py file (two different reasons).  The second has changes upon the first, which is the one we're modifying.  Shall I rollback both, redo, and send you replacement patches for both?

Trial by fire on using Mercurial!

Thanks for the guidance,
Brad Schuler
K0BAS

-----Original Message-----
From: chirp_devel-bounces at intrepid.danplanet.com <chirp_devel-bounces at intrepid.danplanet.com> On Behalf Of Dan Smith via chirp_devel
Sent: Thursday, November 19, 2020 6:05 PM
To: chirp_devel at intrepid.danplanet.com
Subject: Re: [chirp_devel] [PATCH] [AnyTone 5888UV] Add limited squelch mode & fix file identifier

> Is it better (when feedback like this occurs) for me to send a replacement patch or a patch with just these changes to be laid over the one you reviewed?

No, please send a new single patch against the current tip. Multiple patches are fine, but ideally only when the changes are distinct. While iterating on something to get it ready for the tree, I'd rather just apply one thing without the noise in between.

Thanks!

--Dan
_______________________________________________
chirp_devel mailing list
chirp_devel at intrepid.danplanet.com
http://intrepid.danplanet.com/mailman/listinfo/chirp_devel
Developer docs: http://chirp.danplanet.com/projects/chirp/wiki/Developers



More information about the chirp_devel mailing list