[chirp_devel] [PATCH] [TH-UV88] New Model: TYT TH-UV88 (replacement for previous patch)

[Dan Smith]

> # HG changeset patch
> # User Jim Unroe <rock.unroe at gmail.com>
> # Date 1605729943 18000
> #      Wed Nov 18 15:05:43 2020 -0500
> # Node ID 9379757e3946f6da034d96093ad188c9b93dd622
> # Parent  d5e496f563fdfc9ea89dea5f119357235b82db6f
> [TH-UV88] New Model: TYT TH-UV88 (replacement for previous patch)
> 
> This patch adds support for the TYT TH-UV88
> 
> Initial radio protocol decode, channels and memory layout
> by James Berry <james at coppermoth.com>, Summer 2020
> 
> Related to #7817

Can we get an image for testing this?

> +def _clean_buffer(radio):
> +    radio.pipe.timeout = 0.005

This is 5ms, too low to be meaningful on most systems I think, and it looks like this is just for the serial purge. I think something like 100ms is a lot better. I'm not sure how long it takes to read 256 bytes at 57600 but it wouldn't surprise me if this is too short to even clear most buffers.
> 
> +def _make_read_frame(addr, length):
> +    frame = "\xFE\xFE\xEE\xEF\xEB"

This isn't going to be py3 compatible, but I'm so behind on processing this stuff I guess maybe I shouldn't be too picky.

> +    """Pack the info in the header format"""
> +    frame += struct.pack(">ih", addr, length)
> +
> +    frame += "\xFD"
> +    # Return the data
> +    return frame

Also, this does look a *lot* like the icon protocol. Have you tried seeing if the icom radio base will talk to this?

--Dan