[chirp_devel] Revised patch for #8339

[Dan Smith]

> # HG changeset patch
> # User Rick DeWitt <aa0rd at yahoo.com>
> # Date 1605623144 28800
> #      Tue Nov 17 06:25:44 2020 -0800
> # Node ID 3d08cc33c84429bdc1d9d5130f4de58a0470ae31
> # Parent  98b8a850b0f136c77fe09a4922c32a2a28f708be
> [th_uv8000] Issue # 8339, Priority channel: OFF now enabled
> Allowed priority channel number to be 0

Based on this...

> -            val = 1
> -        rx = RadioSettingValueInteger(1, 128, val)
> -        rset = RadioSetting("setstuf.prichan", "Priority Channel", rx)
> +            val = 0
> +        rx = RadioSettingValueInteger(0, 128, val)
> +        rset = RadioSetting("setstuf.prichan", "Priority Channel (0=OFF)", rx)

I ... think ... this val=0 is the actual bug fix, is that right?

Again, please submit the bug fix as a standalone patch with the cleanups as separate. The cleanups you have in here (especially removing the empty returns) is very welcome, I just don't want to mix changes that are supposed to fix something with changes that are supposed to just clean up style stuff. I can apply a lot less scrutiny to the style fixes, but if they're mixed with bug fixes, I have first determine what is fix and what is style, which is hard to do quickly. And, if someone reports something broken later, it's a lot easier to bisect out the actual change that likely broke it.

As a hack, if you have a patch that is *purely* style changes, I'll let you attribute it to "issue #0" to avoid having to open a bug for "style fixes".

Thanks Rick!

--Dan