[chirp_devel] [patch] initial support for AnyTone 778uv
Dan Smith
Wed May 20 15:48:19 PDT 2020
> Thanks for looking through the patch, and thanks for chirp. New patch
> and image attached, which I think covers all your points. I've
> run the test suite with tox, and get a clean sweep with no errors.
Indeed, thanks a lot for making those changes. It's easy to eye-verify the communication routines now (trusting you on the end address of course).
> hexprint() will do nicely, I stole reprdata from my hacky development
> scripts. Done.
Looks like you converted to using it, but didn't remove the definition of the helper. With your permission I'll remove that as it doesn't seem like you depend on it anymore.
> Done, I think, just let me check what I should be doing. Previously I
> was reading in only the bits of memory I knew what to do with, and
> storing them out of order. Understand why that's not desirable, so now
> I'm reading the whole memory, settings and everything, and only
> modifying things I understand.
>
> Is that what you intended?
Yes, with one annotation. If you can avoid reading some of the memory because you know it's empty, but still construct a whole image, it's fine to skip the actual reading to save time. The important part is the consistent image format. What you have now is simple, straightforward, and faithful. If you think it's important to iterate to the performance-optimized version that avoids those reads (as I'm sure the OEM software does) then that's fine, as long as you keep the image in order and whole. In my experience, for small-memory radios it's not that important to avoid three extra seconds downloading, so it's not worth the code complexity, but I'll defer to you as the one with the tactile experience with that specific radio :)
I've applied this version and the image, thanks very much!
--Dan
More information about the chirp_devel
mailing list